build(contracts-rfq): increase optimizer runs to 1M [SLT-294] #3349
Conversation
WalkthroughThe changes introduce a new configuration parameter Changes
Possibly related PRs
Suggested labels
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
packages/contracts-rfq/foundry.toml (1)
5-5: Consider adding a comment explaining the optimization strategy.To help future maintainers understand the reasoning behind this configuration:
[profile.default] # 2024-01-01 block_timestamp = 1_704_067_200 evm_version = "paris" +# High optimizer runs for RFQ contracts to minimize runtime gas costs +# Trade-off: Longer compilation time and higher deployment costs optimizer_runs = 1_000_000
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
- packages/contracts-rfq/foundry.toml (1 hunks)
🔇 Additional comments (1)
packages/contracts-rfq/foundry.toml (1)
5-5: Verify the high optimizer runs value.Setting optimizer_runs to 1M is significantly higher than typical values (200-10000). While this will produce more optimized runtime bytecode, it comes with tradeoffs:
- Longer compilation times
- Higher deployment costs
- Better runtime gas efficiency
Please confirm this aggressive optimization is intentional and consider documenting the rationale.
Deploying sanguine-fe with
|
| Latest commit: |
0a96cec
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ff3553fd.sanguine-fe.pages.dev |
| Branch Preview URL: | https://build-fbv2-optimizer-runs.sanguine-fe.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3349 +/- ##
=============================================
Coverage 34.81813% 34.81813%
=============================================
Files 529 529
Lines 33787 33787
Branches 82 82
=============================================
Hits 11764 11764
Misses 21002 21002
Partials 1021 1021
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Changes to gas cost
🧾 Summary (50% most significant diffs)
Full diff report 👇
|
Description
A clear and concise description of the features you're adding in this pull request.
Additional context
Add any other context about the problem you're solving.
Metadata
Summary by CodeRabbit
fe-releasebranch from triggering the Solidity workflow, streamlining the development process.