Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explorer-ui): removes maintenance banner #3355

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

abtestingalpha
Copy link
Collaborator

@abtestingalpha abtestingalpha commented Oct 31, 2024

Summary by CodeRabbit

  • New Features

    • Removed the Banner component from the app interface for a cleaner user experience.
  • Bug Fixes

    • No bug fixes were included in this release.
  • Documentation

    • No documentation updates were made in this release.

42b623d: explorer-ui preview link

Copy link
Contributor

coderabbitai bot commented Oct 31, 2024

Walkthrough

The changes involve commenting out the Banner component in the packages/explorer-ui/pages/_app.tsx file. This alteration removes the Banner from being rendered in the application while keeping the code intact for potential future use. Other components such as GoogleAnalytics, ApolloProvider, and Analytics remain unchanged, ensuring that the overall functionality of the App component is maintained.

Changes

File Path Change Summary
packages/explorer-ui/pages/_app.tsx Commented out the Banner component definition and usage.

Possibly related PRs

Suggested labels

M-explorer-ui, size/xs

Suggested reviewers

  • bigboydiamonds
  • trajan0x

Poem

In the app where banners used to play,
A quiet change has come today.
With a simple comment, they now rest,
While other features still do their best.
Hop along, dear code, so bright and spry,
For every change, there's a reason why! 🐇✨


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between a330c8b and d1a2608.

📒 Files selected for processing (1)
  • packages/explorer-ui/pages/_app.tsx (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • packages/explorer-ui/pages/_app.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@abtestingalpha abtestingalpha changed the title Removes banner fix(explorer-ui): removes maintenance banner Oct 31, 2024
Copy link

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: d1a2608
Status: ✅  Deploy successful!
Preview URL: https://afb87fc0.sanguine-fe.pages.dev
Branch Preview URL: https://explorer-ui-remove-banner.sanguine-fe.pages.dev

View logs

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.44834%. Comparing base (a330c8b) to head (d1a2608).
Report is 1 commits behind head on master.

Additional details and impacted files
@@                 Coverage Diff                  @@
##              master       #3355          +/-   ##
====================================================
+ Coverage   43.84981%   90.44834%   +46.59853%     
====================================================
  Files             74          54          -20     
  Lines           2317        1026        -1291     
  Branches          82          82                  
====================================================
- Hits            1016         928          -88     
+ Misses          1295          95        -1200     
+ Partials           6           3           -3     
Flag Coverage Δ
packages 90.44834% <ø> (ø)
promexporter ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abtestingalpha abtestingalpha merged commit 049c1a1 into master Oct 31, 2024
38 checks passed
@abtestingalpha abtestingalpha deleted the explorer-ui/remove-banner branch October 31, 2024 16:20
Copy link

codecov bot commented Oct 31, 2024

Bundle Report

Changes will decrease total bundle size by 3.44MB (-9.64%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sdk-router-@synapsecns/sdk-router-esm 255.26kB 609 bytes (0.24%) ⬆️
sdk-router-@synapsecns/sdk-router-cjs 117.55kB 312 bytes (0.27%) ⬆️
explorer-ui-server-cjs 724.74kB 141.33kB (-16.32%) ⬇️
explorer-ui-client-array-push 2.17MB 146.44kB (-6.33%) ⬇️
synapse-interface-client-array-push* 7.49MB 216.93kB (2.98%) ⬆️
synapse-interface-server-cjs* 1.65MB 156.94kB (10.5%) ⬆️
widget-cjs-esm* 271.27kB 2.03kB (-0.74%) ⬇️
docs-bridge-client-array-push* 7.34MB 564.45kB (-7.14%) ⬇️
docs-bridge-server-cjs* 11.57MB 3.31MB (-22.23%) ⬇️
synapse-constants-esm-cjs* 174.63kB 174.63kB (100%) ⬆️
synapse-constants-cjs-esm* 174.18kB 174.18kB (100%) ⬆️

ℹ️ *Bundle size includes cached data from a previous commit

trajan0x added a commit that referenced this pull request Oct 31, 2024
trajan0x added a commit that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant