fix(deps): update dependency @openzeppelin/contracts-4.5.0 to v4.9.6 [security] #3363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
…[security] | datasource | package | from | to | | ---------- | ----------------------- | ----- | ----- | | npm | @openzeppelin/contracts | 4.5.0 | 4.9.6 | Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Deploying sanguine-fe with
|
| Latest commit: |
ab98506
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8013c86e.sanguine-fe.pages.dev |
| Branch Preview URL: | https://renovate-contracts-rfq-npm-o.sanguine-fe.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3363 +/- ##
===================================================
+ Coverage 33.74484% 34.44376% +0.69891%
===================================================
Files 423 429 +6
Lines 27379 27677 +298
Branches 82 82
===================================================
+ Hits 9239 9533 +294
- Misses 17385 17389 +4
Partials 755 755
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
github-actions
bot
deleted the
renovate/contracts-rfq-npm-openzeppelin-contracts-4.5.0-vulnerability
branch
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update ( If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
4.5.0->4.9.6Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
GitHub Vulnerability Alerts
CVE-2024-27094
Impact
The
Base64.encodefunction encodes abytesinput by iterating over it in chunks of 3 bytes. When this input is not a multiple of 3, the last iteration may read parts of the memory that are beyond the input buffer.Although the
encodefunction pads the output for these cases, up to 4 bits of data are kept between the encoding and padding, corrupting the output if these bits were dirty (i.e. memory after the input is not 0). These conditions are more frequent in the following scenarios:bytes memorystruct is allocated just after the input and the first bytes of it are non-zero.Developers should evaluate whether the extra bits can be maliciously manipulated by an attacker.
Patches
Upgrade to 5.0.2 or 4.9.6.
References
This issue was reported by the Independent Security Researcher Riley Holterhus through Immunefi (@rileyholterhus on X)
Release Notes
OpenZeppelin/openzeppelin-contracts (@openzeppelin/contracts-4.5.0)
v4.9.6Compare Source
Base64: Fix issue where dirty memory located just after the input buffer is affecting the result. (#4929)v4.9.5Compare Source
Multicall: Make aware of non-canonical context (i.e.msg.senderis not_msgSender()), allowing compatibility withERC2771Context. Patch duplicatedAddress.functionDelegateCallin v4.9.4 (removed).v4.9.4Compare Source
ERC2771ContextandContext: Introduce a_contextPrefixLength()getter, used to trim extra information appended tomsg.data.Multicall: Make aware of non-canonical context (i.e.msg.senderis not_msgSender()), allowing compatibility withERC2771Context.v4.9.3Compare Source
ERC2771Context: Return the forwarder address whenever themsg.dataof a call originating from a trusted forwarder is not long enough to contain the request signer address (i.e.msg.data.lengthis less than 20 bytes), as specified by ERC-2771. (#4481)ERC2771Context: Prevent revert in_msgData()when a call originating from a trusted forwarder is not long enough to contain the request signer address (i.e.msg.data.lengthis less than 20 bytes). Return the full calldata in that case. (#4484)v4.9.2Compare Source
MerkleProof: Fix a bug inprocessMultiProofandprocessMultiProofCalldatathat allows proving arbitrary leaves if the tree contains a node with value 0 at depth 1.v4.9.1Compare Source
Governor: Add a mechanism to restrict the address of the proposer using a suffix in the description.v4.9.0Compare Source
ReentrancyGuard: Add a_reentrancyGuardEnteredfunction to expose the guard status. (#3714)ERC721Wrapper: add a new extension of theERC721token which wraps an underlying token. Deposit and withdraw guarantee that the ownership of each token is backed by a corresponding underlying token with the same identifier. (#3863)EnumerableMap: add akeys()function that returns an array containing all the keys. (#3920)Governor: add a publiccancel(uint256)function. (#3983)Governor: Enable timestamp operation for blockchains without a stable block time. This is achieved by connecting a Governor's internal clock to match a voting token's EIP-6372 interface. (#3934)Strings: addequalmethod. (#3774)IERC5313: Add an interface for EIP-5313 that is now final. (#4013)IERC4906: Add an interface for ERC-4906 that is now Final. (#4012)StorageSlot: Add support forstringandbytes. (#4008)Votes,ERC20Votes,ERC721Votes: support timestamp checkpointing using EIP-6372. (#3934)ERC4626: Add mitigation to the inflation attack through virtual shares and assets. (#3979)Strings: addtoStringmethod for signed integers. (#3773)ERC20Wrapper: Make theunderlyingvariable private and add a public accessor. (#4029)EIP712: add EIP-5267 support for better domain discovery. (#3969)AccessControlDefaultAdminRules: Add an extension ofAccessControlwith additional security rules for theDEFAULT_ADMIN_ROLE. (#4009)SignatureChecker: AddisValidERC1271SignatureNowfor checking a signature directly against a smart contract using ERC-1271. (#3932)SafeERC20: Add aforceApprovefunction to improve compatibility with tokens behaving like USDT. (#4067)ERC1967Upgrade: removed contract-wideoz-upgrades-unsafe-allow delegatecallannotation, replaced by granular annotation inUUPSUpgradeable. (#3971)ERC20Wrapper: self wrapping and deposit by the wrapper itself are now explicitly forbidden. (#4100)ECDSA: optimize bytes32 computation by using assembly instead ofabi.encodePacked. (#3853)ERC721URIStorage: Emit ERC-4906MetadataUpdatein_setTokenURI. (#4012)ShortStrings: Added a library for handling short strings in a gas efficient way, with fallback to storage for longer strings. (#4023)SignatureChecker: Allow return data length greater than 32 from EIP-1271 signers. (#4038)UUPSUpgradeable: added granularoz-upgrades-unsafe-allow-reachableannotation to improve upgrade safety checks on latest version of the Upgrades Plugins (starting with@openzeppelin/upgrades-core@1.21.0). (#3971)Initializable: optimize_disableInitializersby using!=instead of<. (#3787)Ownable2Step: makeacceptOwnershippublic virtual to enable usecases that require overriding it. (#3960)UUPSUpgradeable.sol: Change visibility to the functionsupgradeToandupgradeToAndCallfromexternaltopublic. (#3959)TimelockController: Add theCallSaltevent to emit on operation schedule. (#4001)Math: optimizelog256rounding check. (#3745)ERC20Votes: optimize by using unchecked arithmetic. (#3748)Multicall: annotatemulticallfunction as upgrade safe to not raise a flag for its delegatecall. (#3961)ERC20Pausable,ERC721Pausable,ERC1155Pausable: Add note regarding missing public pausing functionality (#4007)ECDSA: Add a functiontoDataWithIntendedValidatorHashthat encodes data with version 0x00 following EIP-191. (#4063)MerkleProof: optimize by using unchecked arithmetic. (#3745)Breaking changes
EIP712: Addition of ERC5267 support requires support for user defined value types, which was released in Solidity version 0.8.8. This requires a pragma change from^0.8.0to^0.8.8.EIP712: Optimization of the cache for the upgradeable version affects the waynameandversionare set. This is no longer done through an initializer, and is instead part of the implementation's constructor. As a consequence, all proxies using the same implementation will necessarily share the samenameandversion. Additionally, an implementation upgrade risks changing the EIP712 domain unless the samenameandversionare used when deploying the new implementation contract.Deprecations
ERC20Permit: Added the fileIERC20Permit.solandERC20Permit.soland deprecateddraft-IERC20Permit.solanddraft-ERC20Permit.solsince EIP-2612 is no longer a Draft. Developers are encouraged to update their imports. (#3793)Timers: TheTimerslibrary is now deprecated and will be removed in the next major release. (#4062)ERC777: TheERC777token standard is no longer supported by OpenZeppelin. Our implementation is now deprecated and will be removed in the next major release. The corresponding standard interfaces remain available. (#4066)ERC1820Implementer: TheERC1820pseudo-introspection mechanism is no longer supported by OpenZeppelin. Our implementation is now deprecated and will be removed in the next major release. The corresponding standard interfaces remain available. (#4066)v4.8.3Compare Source
GovernorCompatibilityBravo: Fix encoding of proposal data when signatures are missing.TransparentUpgradeableProxy: Fix transparency in case of selector clash with non-decodable calldata or payable mutability. (#4154)v4.8.2Compare Source
ERC721Consecutive: Fixed a bug when_mintConsecutiveis used for batches of size 1 that could lead to balance overflow. Refer to the breaking changes section in the changelog for a note on the behavior ofERC721._beforeTokenTransfer.Breaking changes
ERC721: The internal function_beforeTokenTransferno longer updates balances, which it previously did whenbatchSizewas greater than 1. This change has no consequence unless a custom ERC721 extension is explicitly invoking_beforeTokenTransfer. Balance updates in extensions must now be done explicitly using__unsafe_increaseBalance, with a name that indicates that there is an invariant that has to be manually verified.v4.8.1Compare Source
ERC4626: Use staticcall instead of call when fetching underlying ERC-20 decimals. (#3943)v4.8.0Compare Source
TimelockController: Added a newadminconstructor parameter that is assigned the admin role instead of the deployer account. (#3722)Initializable: add internal functions_getInitializedVersionand_isInitializing(#3598)ERC165Checker: addsupportsERC165InterfaceUncheckedfor consulting individual interfaces without the full ERC165 protocol. (#3339)Address: optimizefunctionCallby callingfunctionCallWithValuedirectly. (#3468)Address: optimizefunctionCallfunctions by checking contract size only if there is no returned data. (#3469)Governor: make therelayfunction payable, and add support for EOA payments. (#3730)GovernorCompatibilityBravo: remove unusedusingstatements. (#3506)ERC20: optimize_transfer,_mintand_burnby usinguncheckedarithmetic when possible. (#3513)ERC20Votes,ERC721Votes: optimizegetPastVotesfor looking up recent checkpoints. (#3673)ERC20FlashMint: add an internal_flashFeefunction for overriding. (#3551)ERC4626: use the samedecimals()as the underlying asset by default (if available). (#3639)ERC4626: add internal_initialConvertToSharesand_initialConvertToAssetsfunctions to customize empty vaults behavior. (#3639)ERC721: optimize transfers by making approval clearing implicit instead of emitting an event. (#3481)ERC721: optimize burn by making approval clearing implicit instead of emitting an event. (#3538)ERC721: Fix balance accounting when a custom_beforeTokenTransferhook results in a transfer of the token under consideration. (#3611)ERC721: use unchecked arithmetic for balance updates. (#3524)ERC721Consecutive: Implementation of EIP-2309 that allows batch minting of ERC721 tokens during construction. (#3311)ReentrancyGuard: Reduce code size impact of the modifier by using internal functions. (#3515)SafeCast: optimize downcasting of signed integers. (#3565)ECDSA: Remove redundant check on thevvalue. (#3591)VestingWallet: addreleasablegetters. (#3580)VestingWallet: remove unused libraryMath.sol. (#3605)VestingWallet: make constructor payable. (#3665)Create2: optimize address computation by using assembly instead ofabi.encodePacked. (#3600)Clones: optimized the assembly to use only the scratch space during deployments, and optimizedpredictDeterministicAddressto use fewer operations. (#3640)Checkpoints: Use procedural generation to support multiple key/value lengths. (#3589)Checkpoints: Add new lookup mechanisms. (#3589)Arrays: AddunsafeAccessfunctions that allow reading and writing to an element in a storage array bypassing Solidity's "out-of-bounds" check. (#3589)Strings: optimizetoString. (#3573)Ownable2Step: extension ofOwnablethat makes the ownership transfers a two step process. (#3620)MathandSignedMath: optimize functionmaxby using>instead of>=. (#3679)Math: Addlog2,log10andlog256. (#3670)Breaking changes
ERC721: In order to add support for batch minting viaERC721Consecutiveit was necessary to make a minor breaking change in the internal interface ofERC721. Namely, the hooks_beforeTokenTransferand_afterTokenTransferhave one additional argument that may need to be added to overrides:function _beforeTokenTransfer( address from, address to, uint256 tokenId, + uint256 batchSize ) internal virtual overrideERC4626: Conversion from shares to assets (and vice-versa) in an empty vault used to consider the possible mismatch between the underlying asset's and the vault's decimals. This initial conversion rate is now set to 1-to-1 irrespective of decimals, which are meant for usability purposes only. The vault now uses the assets decimals by default, so off-chain the numbers should appear the same. Developers overriding the vault decimals to a value that does not match the underlying asset may want to override the_initialConvertToSharesand_initialConvertToAssetsto replicate the previous behavior.TimelockController: During deployment, the TimelockController used to grant theTIMELOCK_ADMIN_ROLEto the deployer and to the timelock itself. The deployer was then expected to renounce this role once configuration of the timelock is over. Failing to renounce that role allows the deployer to change the timelock permissions (but not to bypass the delay for any time-locked actions). The role is no longer given to the deployer by default. A new parameteradmincan be set to a non-zero address to grant the admin role during construction (to the deployer or any other address). Just like previously, this admin role should be renounced after configuration. If this param is givenaddress(0), the role is not allocated and doesn't need to be revoked. In any case, the timelock itself continues to have this role.Deprecations
EIP712: Added the fileEIP712.soland deprecateddraft-EIP712.solsince the EIP is no longer a Draft. Developers are encouraged to update their imports. (#3621)ERC721Votes: Added the fileERC721Votes.soland deprecateddraft-ERC721Votes.solsince it no longer depends on a Draft EIP (EIP-712). Developers are encouraged to update their imports. (#3699)ERC-721 Compatibility Note
ERC-721 integrators that interpret contract state from events should make sure that they implement the clearing of approval that is implicit in every transfer according to the EIP. Previous versions of OpenZeppelin Contracts emitted an explicit
Approvalevent even though it was not required by the specification, and this is no longer the case.With the new
ERC721Consecutiveextension, the internal workings ofERC721are slightly changed. Custom extensions to ERC721 should be reviewed to ensure they remain correct. The internal functions that should be considered are_ownerOf(new),_beforeTokenTransfer, and_afterTokenTransfer.ERC-4626 Upgrade Note
Existing
ERC4626contracts that are upgraded to 4.8 must initialize a new variable that holds the vault token decimals. The recommended way to do this is to use a reinitializer:v4.7.3Compare Source
Breaking changes
ECDSA:recover(bytes32,bytes)andtryRecover(bytes32,bytes)no longer accept compact signatures to prevent malleability. Compact signature support remains available usingrecover(bytes32,bytes32,bytes32)andtryRecover(bytes32,bytes32,bytes32).v4.7.2Compare Source
LibArbitrumL2,CrossChainEnabledArbitrumL2: Fixed detection of cross-chain calls for EOAs. Previously, calls from EOAs would be classified as cross-chain calls. (#3578)GovernorVotesQuorumFraction: Fixed quorum updates so they do not affect past proposals that failed due to lack of quorum. (#3561)ERC165Checker: Added protection against large returndata. (#3587)v4.7.1Compare Source
SignatureChecker: Fix an issue that causesisValidSignatureNowto revert when the target contract returns ill-encoded data. (#3552)ERC165Checker: Fix an issue that causessupportsInterfaceto revert when the target contract returns ill-encoded data. (#3552)v4.7.0Compare Source
TimelockController: Migrate_callto_executeand allow inheritance and overriding similar toGovernor. (#3317)CrossChainEnabledPolygonChild: replace therequirestatement with the custom errorNotCrossChainCall. (#3380)ERC20FlashMint: Add customizable flash fee receiver. (#3327)ERC4626: add an extension ofERC20that implements the ERC4626 Tokenized Vault Standard. (#3171)SafeERC20: addsafePermitas mitigation against phantom permit functions. (#3280)Math: add amulDivfunction that can round the result either up or down. (#3171)Math: Add asqrtfunction to compute square roots of integers, rounding either up or down. (#3242)Strings: add a new overloaded functiontoHexStringthat converts anaddresswith fixed length of 20 bytes to its not checksummed ASCIIstringhexadecimal representation. (#3403)EnumerableMap: add newUintToUintMapmap type. (#3338)EnumerableMap: add newBytes32ToUintMapmap type. (#3416)SafeCast: add support for many more types, using procedural code generation. (#3245)MerkleProof: addmultiProofVerifyto prove multiple values are part of a Merkle tree. (#3276)MerkleProof: add calldata versions of the functions to avoid copying input arrays to memory and save gas. (#3200)ERC721,ERC1155: simplified revert reasons. (#3254, (#3438))ERC721: removed redundant require statement. (#3434)PaymentSplitter: addreleasablegetters. (#3350)Initializable: refactored implementation of modifiers for easier understanding. (#3450)Proxies: remove runtime check of ERC1967 storage slots. (#3455)Breaking changes
Initializable: functions decorated with the modifierreinitializer(1)may no longer invoke each other.v4.6.0Compare Source
crosschain: Add a new set of contracts for cross-chain applications.CrossChainEnabledis a base contract with instantiations for several chains and bridges, andAccessControlCrossChainis an extension of access control that allows cross-chain operation. (#3183)AccessControl: add a virtual_checkRole(bytes32)function that can be overridden to alter theonlyRolemodifier behavior. (#3137)EnumerableMap: add newAddressToUintMapmap type. (#3150)EnumerableMap: add newBytes32ToBytes32Mapmap type. (#3192)ERC20FlashMint: support infinite allowance when paying back a flash loan. (#3226)ERC20Wrapper: thedecimals()function now tries to fetch the value from the underlying token instance. If that calls revert, then the default value is used. (#3259)draft-ERC20Permit: replaceimmutablewithconstantfor_PERMIT_TYPEHASHsince thekeccak256of string literals is treated specially and the hash is evaluated at compile time. (#3196)ERC1155: Add a_afterTokenTransferhook for improved extensibility. (#3166)ERC1155URIStorage: add a new extension that implements a_setURIbehavior similar to ERC721's_setTokenURI. (#3210)DoubleEndedQueue: a new data structure that supports efficient push and pop to both front and back, useful for FIFO and LIFO queues. (#3153)Governor: improved security ofonlyGovernancemodifier when using an external executor contract (e.g. a timelock) that can operate without necessarily going through the governance protocol. (#3147)Governor: Add a way to parameterize votes. This can be used to implement voting systems such as fractionalized voting, ERC721 based voting, or any number of other systems. Theparamsargument added to_countVotemethod, and included in the newly added_getVotesmethod, can be used by counting and voting modules respectively for such purposes. (#3043)Governor: rewording of revert reason for consistency. (#3275)Governor: fix an inconsistency in data locations that could lead to invalid bytecode being produced. (#3295)Governor: ImplementIERC721ReceiverandIERC1155Receiverto improve token custody by governors. (#3230)TimelockController: ImplementIERC721ReceiverandIERC1155Receiverto improve token custody by timelocks. (#3230)TimelockController: Add a separate canceller role for the ability to cancel. (#3165)Initializable: add a reinitializer modifier that enables the initialization of new modules, added to already initialized contracts through upgradeability. (#3232)Initializable: add an Initialized event that tracks initialized version numbers. (#3294)ERC2981: makeroyaltyInfopublic to allow super call in overrides. (#3305)Upgradeability notice
TimelockController: (Action needed) The upgrade from <4.6 to >=4.6 introduces a newCANCELLER_ROLEthat requires set up to be assignable. After the upgrade, only addresses with this role will have the ability to cancel. Proposers will no longer be able to cancel. Assigning cancellers can be done by an admin (including the timelock itself) once the role admin is set up. To do this, we recommend upgrading to theTimelockControllerWith46MigrationUpgradeablecontract and then calling themigrateTo46function.Breaking changes
Governor: Adds internal virtual_getVotesmethod that must be implemented; this is a breaking change for existing concrete extensions toGovernor. To fix this on an existing voting module extension, renamegetVotesto_getVotesand add abytes memoryargument. (#3043)Governor: Addsparamsparameter to internal virtual_countVotemethod; this is a breaking change for existing concrete extensions toGovernor. To fix this on an existing counting module extension, add abytes memoryargument to_countVote. (#3043)Governor: Does not emitVoteCastevent when params data is non-empty; instead emitsVoteCastWithParamsevent. To fix this on an integration that consumes theVoteCastevent, also fetch/monitorVoteCastWithParamsevents. (#3043)Votes: The internal virtual function_getVotingUnitswas madeview(which was accidentally missing). Any overrides should now be updated so they areviewas well.Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.