Pin terraform-aws-modules/vpc/aws version 3.7 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spruce-bruce
approved these changes
Oct 20, 2021
chestercharles
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
terraform-aws-modules/vpc/awsv3.8 drops support for terraform v0.12.x.. This is preventing us from deploying puppies infra until we update our terraform to v0.13.x.It looks like Kyle was messing around with this module before he left - he released a handful of versions an ultimately removed the pin and I unfortunately don't know why.
I'd like to create a 2.0.5 release with this change and update puppies infra to point at that.
A search for this module in our organization shows a couple projects are referencing it, but they are pinned to either a version or a commit, so looks like this change should be safe.