Fix capHeader.pid type #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In C, int is 4 bytes in 32 and 64-bit systems. In Go, int is a 8 bytes in 64-bit systems. Before this fix, pid was being ignored because the kernel will always read 0 due to padding added between version and pid fields.
thaJeztah
added a commit
to thaJeztah/runc
that referenced
this pull request
Mar 28, 2019
relevant changes: - syndtr/gocapability#14 capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2 - syndtr/gocapability#16 Fix capHeader.pid type Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/runc
that referenced
this pull request
Mar 28, 2019
relevant changes: - syndtr/gocapability#14 capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2 - syndtr/gocapability#16 Fix capHeader.pid type Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/runc
that referenced
this pull request
Apr 12, 2019
relevant changes: - syndtr/gocapability#14 capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2 - syndtr/gocapability#16 Fix capHeader.pid type Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/runc
that referenced
this pull request
Apr 12, 2019
relevant changes: - syndtr/gocapability#14 capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2 - syndtr/gocapability#16 Fix capHeader.pid type Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/runc
that referenced
this pull request
Apr 12, 2019
relevant changes: - syndtr/gocapability#14 capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2 - syndtr/gocapability#16 Fix capHeader.pid type Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
Apr 14, 2019
full diff: syndtr/gocapability@2c00dae...d983527 relevant changes: - syndtr/gocapability#11 Add support for ambient capabilities - syndtr/gocapability#13 Fix issue moby#12: break too early - syndtr/gocapability#16 Fix capHeader.pid type Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Apr 16, 2019
full diff: syndtr/gocapability@2c00dae...d983527 relevant changes: - syndtr/gocapability#11 Add support for ambient capabilities - syndtr/gocapability#13 Fix issue #12: break too early - syndtr/gocapability#16 Fix capHeader.pid type Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: da1fbb3f2bb8dbe9393fe2328701b900ef1462f4 Component: engine
thaJeztah
added a commit
to thaJeztah/containerd
that referenced
this pull request
Apr 18, 2019
full diff: syndtr/gocapability@db04d3c...d983527 changes included: - syndtr/gocapability#14 capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2 - syndtr/gocapability#16 Fix capHeader.pid type Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
kiwik
pushed a commit
to theopenlab/containerd
that referenced
this pull request
Apr 23, 2019
* Add tcp service for grpc listeners Signed-off-by: Michael Crosby <crosbymichael@gmail.com> * Set nofile to 1048576 Closes containerd#3201 Signed-off-by: Michael Crosby <crosbymichael@gmail.com> * Fix API forward events for shims Signed-off-by: Michael Crosby <crosbymichael@gmail.com> * Add support for required plugins. Signed-off-by: Lantao Liu <lantaol@google.com> * Use $TEST_RUNTIME for cri test. Signed-off-by: Lantao Liu <lantaol@google.com> * Improve shim shutdown logic Shims no longer call `os.Exit` but close the context on shutdown so that events and other resources have hit the `defer`s. Signed-off-by: Michael Crosby <crosbymichael@gmail.com> * Add dialer for events service Signed-off-by: Michael Crosby <crosbymichael@gmail.com> * Rename `hrpc` to `tcpServer` Signed-off-by: Michael Crosby <crosbymichael@gmail.com> * Check task list to avoid unnecessary cleanup. Signed-off-by: Lantao Liu <lantaol@google.com> * Correct import path in services/server package Signed-off-by: Jared Cordasco <jcordasc@coglib.com> * Correct PusherFunc helper to match Pusher intf Signed-off-by: Jared Cordasco <jcordasc@coglib.com> * Requeue events in the shim publisher Signed-off-by: Michael Crosby <crosbymichael@gmail.com> * bump mistifyio/go-zfs f784269be439d704d3dfa1906f45dd848fed2beb - mistifyio/go-zfs#72 Switch to google/uuid - removes the github.com/pborman/uuid dependency Signed-off-by: Sebastiaan van Stijn <github@gone.nl> * Update go-winio in vendor.conf Signed-off-by: Kevin Parsons <kevpar@microsoft.com> * Allow dumping stacks via ETW capture state Signed-off-by: Kevin Parsons <kevpar@microsoft.com> * Access to client's GRPC connection object Signed-off-by: Maksym Pavlenko <makpav@amazon.com> * .mailmap: update Akihiro Suda's email address No affiliation change (NTT). The former email address will continue to be available for the time being. For daily communication, I still prefer to use my gmail.com address. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp> * Move to sha-specified test image for nanoserver Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com> * Fix error on pull hang in CI Kill the underlying containerd after outputting error. Otherwise CI hangs indefinitely and requires the CI infrastructure to kill the build at the timeout expiration. Signed-off-by: Wei Fu <fuweid89@gmail.com> Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com> * Write stack dump to `os.TempDir()` as well Signed-off-by: John Howard <jhoward@microsoft.com> * bump gocapability full diff: syndtr/gocapability@db04d3c...d983527 changes included: - syndtr/gocapability#14 capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2 - syndtr/gocapability#16 Fix capHeader.pid type Signed-off-by: Sebastiaan van Stijn <github@gone.nl> * Update x/crypto to 88737f569e3a9c7ab309cdc09a07fe7fc87233c3 full diff: golang/crypto@4979611...88737f5 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> * bump containerd/console 0650fd9eeb50bab4fc99dceb9f2e14cf58f36e7f Signed-off-by: Sebastiaan van Stijn <github@gone.nl> * Convert Windows CI to use Microsoft MCR image urls Signed-off-by: Justin Terry (VM) <juterry@microsoft.com> * Don't write dumped stacks to file for ETW capture state Signed-off-by: Kevin Parsons <kevpar@microsoft.com>
thaJeztah
added a commit
to thaJeztah/runc
that referenced
this pull request
Apr 25, 2019
relevant changes: - syndtr/gocapability#14 capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2 - syndtr/gocapability#16 Fix capHeader.pid type Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
kiku-jw
pushed a commit
to kiku-jw/moby
that referenced
this pull request
May 16, 2019
full diff: syndtr/gocapability@2c00dae...d983527 relevant changes: - syndtr/gocapability#11 Add support for ambient capabilities - syndtr/gocapability#13 Fix issue moby#12: break too early - syndtr/gocapability#16 Fix capHeader.pid type Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/runc
that referenced
this pull request
Jul 14, 2019
relevant changes: - syndtr/gocapability#14 capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2 - syndtr/gocapability#16 Fix capHeader.pid type Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/runc
that referenced
this pull request
Aug 26, 2019
relevant changes: - syndtr/gocapability#14 capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2 - syndtr/gocapability#16 Fix capHeader.pid type Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/runc
that referenced
this pull request
Sep 5, 2019
relevant changes: - syndtr/gocapability#14 capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2 - syndtr/gocapability#16 Fix capHeader.pid type Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Dec 31, 2019
relevant changes: - syndtr/gocapability#14 capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2 - syndtr/gocapability#16 Fix capHeader.pid type Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
adrianreber
pushed a commit
to adrianreber/runc
that referenced
this pull request
Feb 10, 2020
relevant changes: - syndtr/gocapability#14 capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2 - syndtr/gocapability#16 Fix capHeader.pid type Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In C, int is 4 bytes in 32 and 64-bit systems. In Go, int is a
8 bytes in 64-bit systems. Before this fix, pid was being ignored
because the kernel will always read 0 due to padding added between
version and pid fields.