addressed review comment by removing unused method parameter.

synopsys-sig · Oct 11, 2023 · 5b45d21 · 5b45d21
1 parent 6df70fc
commit 5b45d21
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/main/java/com/synopsys/integration/jenkins/scan/extension/pipeline/SecurityScanStep.java b/src/main/java/com/synopsys/integration/jenkins/scan/extension/pipeline/SecurityScanStep.java
@@ -380,7 +380,7 @@ public void setNetwork_airgap(Boolean network_airgap) {
 
     private Map<String, Object> getParametersMap(FilePath workspace, TaskListener listener) throws PluginExceptionHandler {
         return ScanParametersFactory.preparePipelineParametersMap(this,
-                ScanParametersFactory.getGlobalConfigurationValues(workspace, listener), workspace, listener);
+                ScanParametersFactory.getGlobalConfigurationValues(workspace, listener), listener);
     }
 
     @Override

diff --git a/src/main/java/com/synopsys/integration/jenkins/scan/factory/ScanParametersFactory.java b/src/main/java/com/synopsys/integration/jenkins/scan/factory/ScanParametersFactory.java
@@ -49,7 +49,7 @@ public static PluginParametersHandler createPipelineCommand(Run<?, ?> run, TaskL
     }
 
     public static Map<String, Object> preparePipelineParametersMap(SecurityScanStep scanStep, Map<String, Object> parametersMap,
-                                                                   FilePath workspace, TaskListener listener) throws PluginExceptionHandler {
+                                                                   TaskListener listener) throws PluginExceptionHandler {
         String product = scanStep.getProduct();
 
         if(validateProduct(product, listener)) {

diff --git a/src/test/java/com/synopsys/integration/jenkins/scan/factory/ScanParametersFactoryTest.java b/src/test/java/com/synopsys/integration/jenkins/scan/factory/ScanParametersFactoryTest.java
@@ -43,7 +43,7 @@ public void preparePipelineParametersMapTest() throws AbortException, PluginExce
         globalConfigValues.put(ApplicationConstants.SYNOPSYS_BRIDGE_INSTALL_DIRECTORY, "/fake/path");
 
         Map<String, Object> result = scanParametersFactory.preparePipelineParametersMap(securityScanStep,
-                globalConfigValues, workspace, listenerMock);
+                globalConfigValues, listenerMock);
 
         assertEquals(5, result.size());
         assertEquals("BLACKDUCK", result.get(ApplicationConstants.PRODUCT_KEY));
@@ -54,7 +54,7 @@ public void preparePipelineParametersMapTest() throws AbortException, PluginExce
         securityScanStep.setProduct("invalid-product");
 
         assertThrows(PluginExceptionHandler.class, () -> scanParametersFactory.preparePipelineParametersMap(securityScanStep,
-                globalConfigValues, workspace, listenerMock));
+                globalConfigValues, listenerMock));
     }
 
     @Test