This repository has been archived by the owner on Feb 28, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jahid1209
commented
Oct 9, 2023
- Added unit tests to improve code coverage from 54% to 72%.
…canParametersFactory to increase code coverage.
jahid1209
requested review from
sadmananik,
zaman-akib and
maksudur-rahman-maruf
October 9, 2023 13:00
zaman-akib
approved these changes
Oct 11, 2023
src/main/java/com/synopsys/integration/jenkins/scan/factory/ScanParametersFactory.java
Outdated
Show resolved
Hide resolved
globalConfigValues.put(ApplicationConstants.BLACKDUCK_TOKEN_KEY, "fake-blackduck-token"); | ||
globalConfigValues.put(ApplicationConstants.SYNOPSYS_BRIDGE_INSTALL_DIRECTORY, "/fake/path"); | ||
|
||
Map<String, Object> result = scanParametersFactory.preparePipelineParametersMap(securityScanStep, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, preparePipelineParametersMap
static method is accessed by the instance reference. I think static method should be accessed by the class name.
src/test/java/com/synopsys/integration/jenkins/scan/factory/ScanParametersFactoryTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/synopsys/integration/jenkins/scan/factory/ScanParametersFactoryTest.java
Show resolved
Hide resolved
src/test/java/com/synopsys/integration/jenkins/scan/factory/ScanParametersFactoryTest.java
Show resolved
Hide resolved
src/test/java/com/synopsys/integration/jenkins/scan/factory/ScanParametersFactoryTest.java
Show resolved
Hide resolved
src/test/java/com/synopsys/integration/jenkins/scan/factory/ScanParametersFactoryTest.java
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.