Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves Search and Show Number Find #1839

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Improves Search and Show Number Find #1839

merged 3 commits into from
Oct 3, 2024

Conversation

stolinski
Copy link
Collaborator

Fixes all of #1668

Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
syntax-website ✅ Ready (Inspect) Visit Preview Sep 30, 2024 8:12pm

Copy link

codecov bot commented Sep 30, 2024

Bundle Report

Changes will increase total bundle size by 1.32kB (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
website-client-esm 2.29MB 233 bytes (0.01%) ⬆️
website-server-esm 30.89MB 1.09kB (0.0%) ⬆️

@stolinski
Copy link
Collaborator Author

I have no idea why the pw tests are suddenly failing here. It looks like some kind of out of memory issue? I ran them locally and they all passed. Nohting I changed will affect that, so maybe we are just good to merge and figure out why they aren't passing after?

@stolinski stolinski marked this pull request as ready for review October 1, 2024 21:26
@stolinski stolinski requested a review from w3cj October 2, 2024 15:47
@wesbos
Copy link
Collaborator

wesbos commented Oct 2, 2024

LG™ - I tested that the redirects still work

@stolinski stolinski merged commit 1274b2d into main Oct 3, 2024
4 of 5 checks passed
@stolinski stolinski deleted the search-improve branch October 3, 2024 14:08
github-actions bot added a commit that referenced this pull request Oct 3, 2024
* adds show number to search

* adds redirects for /show/num and /num removes middleware

* removes throw from redirect 2.1.136
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants