Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desktop builds show null (null) for the version #398

Open
EdGeraghty opened this issue Nov 3, 2021 · 2 comments
Open

Desktop builds show null (null) for the version #398

EdGeraghty opened this issue Nov 3, 2021 · 2 comments
Labels
desktop Potentially refers to a desktop only issue UI/UX View only feature

Comments

@EdGeraghty
Copy link
Collaborator

Need to work out where we set the version value for the Windows builds

image
@EdGeraghty
Copy link
Collaborator Author

#420 at least sets the version on the executable, until such a time as this isn't blocked by upstream

image

@moan0s
Copy link

moan0s commented Apr 7, 2022

Same on Linux for version syphon-bin 0.2.12-1 from the AUR

@EdGeraghty EdGeraghty changed the title Windows builds show null (null) for the version Desktop builds show null (null) for the version Apr 7, 2022
@EdGeraghty EdGeraghty added UI/UX View only feature blocked Blocked by external dependency (Flutter, Olm, etc) desktop Potentially refers to a desktop only issue labels Apr 7, 2022
@EdGeraghty EdGeraghty removed the blocked Blocked by external dependency (Flutter, Olm, etc) label Aug 13, 2022
EdGeraghty pushed a commit that referenced this issue Aug 13, 2022
Migrate from deprecated package_info to package_info_plus
1752971 
Fixes #398
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
desktop Potentially refers to a desktop only issue UI/UX View only feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EdGeraghty @moan0s