Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: expand single filename legal characters #398

Merged
merged 7 commits into from
Nov 13, 2020
Merged

fix: expand single filename legal characters #398

merged 7 commits into from
Nov 13, 2020

Conversation

iamogbz
Copy link
Collaborator

@iamogbz iamogbz commented Oct 29, 2020 •
edited
Loading

Description

Closes #400; Allow any character in a snapshot file name except

  • \s gets replaced with _
  • \/?%*:|"<>,;= get dropped
  • Control characters (C) get dropped

Checklist

  • This PR has sufficient documentation.
  • This PR has sufficient test coverage.
  • This PR title satisfies semantic convention.

Additional Comments

@iamogbz iamogbz requested a review from noahnu October 29, 2020 07:11
@codecov
Copy link

codecov bot commented Oct 29, 2020 •
edited
Loading

Codecov Report

Merging #398 (530804a) into master (03d71d1) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #398   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         1023      1025    +2     
=========================================
+ Hits          1023      1025    +2

noahnu
noahnu previously approved these changes Oct 29, 2020
View reviewed changes
Copy link
Collaborator

@noahnu noahnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. It is a breaking change though

@iamogbz iamogbz marked this pull request as draft October 30, 2020 00:23
@iamogbz iamogbz added the feature request New feature or request label Oct 30, 2020
@iamogbz iamogbz closed this Oct 30, 2020
@iamogbz iamogbz deleted the expand-legal-characters branch October 30, 2020 02:25
@iamogbz iamogbz mentioned this pull request Oct 30, 2020
Closed
@noahnu noahnu restored the expand-legal-characters branch November 12, 2020 02:28
@noahnu noahnu reopened this Nov 12, 2020
@noahnu noahnu force-pushed the expand-legal-characters branch from c5f437a to 3d08dab Compare November 12, 2020 02:30
@noahnu noahnu marked this pull request as ready for review November 12, 2020 02:52
@iamogbz iamogbz requested a review from noahnu November 13, 2020 02:11
@iamogbz iamogbz requested a review from noahnu November 13, 2020 02:24
@iamogbz iamogbz merged commit 14a9667 into master Nov 13, 2020
@iamogbz iamogbz deleted the expand-legal-characters branch November 13, 2020 02:41
syrupy-bot pushed a commit that referenced this pull request Nov 13, 2020
@semantic-release-bot
chore(release): 0.8.5 [skip ci]
89fbd47 
## [0.8.5](v0.8.4...v0.8.5) (2020-11-13)

### Bug Fixes

* expand single filename legal characters ([#398](#398)) ([14a9667](14a9667))
iamogbz added a commit that referenced this pull request Nov 13, 2020
@iamogbz
feat: expand single filename legal characters (#398)
302916b
syrupy-bot pushed a commit that referenced this pull request Nov 13, 2020
@semantic-release-bot
chore(release): 0.9.0 [skip ci]
7cd8326 
# [0.9.0](v0.8.5...v0.9.0) (2020-11-13)

### Features

* expand single filename legal characters ([#398](#398)) ([302916b](302916b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahnu noahnu noahnu approved these changes

Assignees
No one assigned
Labels
feature request New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expand single filename default allowed character set
2 participants
@iamogbz @noahnu