Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The recent release of the 'colored' package is breaking 'syrupy' #758

Closed
behnazh-w opened this issue Jun 19, 2023 · 6 comments
Closed

The recent release of the 'colored' package is breaking 'syrupy' #758

behnazh-w opened this issue Jun 19, 2023 · 6 comments
Labels
released

Comments

@behnazh-w
Copy link

Describe the bug

The colored package that syrupy depends on has released version 1.5.0 and it's breaking syrupy with this error:

AttributeError: module 'colored' has no attribute 'fg'
@scott-boost scott-boost mentioned this issue Jun 19, 2023
Closed
@noahnu
Copy link
Collaborator

noahnu commented Jun 19, 2023 •
edited
Loading

They're not following semver? I'd expect that to be a breaking change.

Since it's just a rename, we should be able to have some interop logic support both versions for some time.

I welcome a pull request for this, otherwise will prioritize this first thing this week.

@noahnu
Copy link
Collaborator

noahnu commented Jun 19, 2023

It looks like colored 1.5.0 also raised the min. python version to 3.9, so it won't be easy to test here. I'll have to QA this manually unfortunately.

noahnu pushed a commit that referenced this issue Jun 19, 2023
fix: support colored >=1.5.0 dependency, close #758
251a653
@behnazh-w
Copy link
Author

They're not following semver? I'd expect that to be a breaking change.

No, I don't think they're following semver :-(

@noahnu
Copy link
Collaborator

noahnu commented Jun 19, 2023

Asked for clarification on the colored repository: https://gitlab.com/dslackw/colored/-/issues/27. In the meantime, I'll release a backwards compatible fix for syrupy.

@noahnu noahnu closed this as completed in 783fc5c Jun 19, 2023
behnazh-w added a commit to oracle/macaron that referenced this issue Jun 19, 2023
@behnazh-w
chore(deps-dev): add colored package to resolve issue in syrupy
0607132 
A breaking change in colored package is causing syrupy to fail.

As a temporary solution, we have to add colored as a test dependency and avoid using version 1.5.0.

See see: syrupy-project/syrupy#758

Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
tophat-opensource-bot pushed a commit that referenced this issue Jun 19, 2023
@semantic-release-bot
chore(release): 4.0.3 [skip ci]
eb3183d 
## [4.0.3](v4.0.2...v4.0.3) (2023-06-19)

### Bug Fixes

* support colored >=1.5.0 dependency, close [#758](#758) ([#760](#760)) ([783fc5c](783fc5c))
@tophat-opensource-bot
Copy link
Contributor

🎉 This issue has been resolved in version 4.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@behnazh-w behnazh-w mentioned this issue Jun 19, 2023
Closed
@noahnu noahnu pinned this issue Jun 19, 2023
@noahnu
Copy link
Collaborator

noahnu commented Aug 28, 2023

The colored dependency has been removed.

@noahnu noahnu unpinned this issue Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@noahnu @behnazh-w @tophat-opensource-bot