Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: v0.4.0 - Amber serializer changes #192

Merged
merged 2 commits into from
Apr 19, 2020
Merged

feat: v0.4.0 - Amber serializer changes #192

merged 2 commits into from
Apr 19, 2020

Conversation

noahnu
Copy link
Collaborator

@noahnu noahnu commented Apr 17, 2020

Description

v0.4.0 contains some breaking changes to the amber snapshot serializer.

Related Issues

Checklist

  • This PR has sufficient test coverage.
  • I will merge this pull request with a semantic title.

@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #192 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #192   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines          868       868           
=========================================
  Hits           868       868           

@noahnu noahnu requested a review from iamogbz April 18, 2020 16:35
iamogbz
iamogbz previously approved these changes Apr 19, 2020
Copy link
Collaborator

@iamogbz iamogbz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iamogbz
Copy link
Collaborator

iamogbz commented Apr 19, 2020

@noahnu should probably be merged with a merge commit rather than a squash

@noahnu noahnu merged commit bc0acf3 into master Apr 19, 2020
@noahnu noahnu deleted the next-v0.4.0 branch April 19, 2020 17:43
@syrupy-bot
Copy link
Contributor

🎉 This PR is included in version 0.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants