Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(vm, cloud-scan): single-project use-case #18

Merged
merged 21 commits into from
Mar 19, 2024
Merged

test(vm, cloud-scan): single-project use-case #18

merged 21 commits into from
Mar 19, 2024

Conversation

wideawakening
Copy link
Contributor

@wideawakening wideawakening commented Jan 29, 2024 •
edited
Loading

tasks

side-quest

  • ✅ passed pre-commit linter on agentless-scan files

usage
see test/examples/agentless-scan/single/main.tf

context
goes together with consumption sample https://github.com/draios/secure-backend/pull/26487

doubt

  • should we add the terraform provider resources within module, on onboarding (like AWS) or outside (like GCP/Azure?

@wideawakening wideawakening changed the title feat: vm agentless onboarding feat: vm agentless onboarding [SSPROD-35921] Jan 29, 2024
@wideawakening wideawakening changed the title feat: vm agentless onboarding [SSPROD-35921] feat(agentless-scan): onboarding adaptations [SSPROD-35921] Jan 30, 2024
@wideawakening wideawakening changed the title feat(agentless-scan): onboarding adaptations [SSPROD-35921] feat(agentless-scan): onboarding provider usage [SSPROD-35921] Jan 30, 2024
@wideawakening wideawakening changed the title feat(agentless-scan): onboarding provider usage [SSPROD-35921] test(vm, cloudscan): onboarding provider usage [SSPROD-35921] Feb 28, 2024
@wideawakening wideawakening changed the title test(vm, cloudscan): onboarding provider usage [SSPROD-35921] test(vm, cloud-scan): onboarding provider usage Mar 6, 2024
@wideawakening wideawakening marked this pull request as ready for review March 11, 2024 10:11
@wideawakening wideawakening requested review from a team as code owners March 11, 2024 10:11
@wideawakening wideawakening changed the title test(vm, cloud-scan): onboarding provider usage test(vm, cloud-scan): single-project use-case Mar 11, 2024
@wideawakening wideawakening mentioned this pull request Mar 11, 2024
Merged
@wideawakening wideawakening enabled auto-merge (squash) March 12, 2024 07:18
haresh-suresh
haresh-suresh approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@haresh-suresh haresh-suresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

iru added 5 commits March 19, 2024 08:54
Merge branch 'master' into gcp-agentless-onboarding
8b8072a 
# Conflicts:
#	.github/workflows/ci-pull-request.yaml
#	modules/services/agentless-scan/data.tf
#	modules/services/agentless-scan/variables.tf
#	modules/services/agentless-scan/worker.tf
ci: merge master
efdf924
Merge remote-tracking branch 'origin/gcp-agentless-onboarding' into g…
4a82c11 
…cp-agentless-onboarding
ci: pre-commit
1ec277c
ci: pre-commit
3aec6a5
@wideawakening wideawakening merged commit 487b2ad into master Mar 19, 2024
8 checks passed
@wideawakening wideawakening deleted the gcp-agentless-onboarding branch March 19, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haresh-suresh haresh-suresh haresh-suresh approved these changes

@marcuzzuu marcuzzuu marcuzzuu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wideawakening @marcuzzuu @haresh-suresh