-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(routing-key): enable routing key generation in a deterministic way #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgeers
reviewed
Oct 15, 2024
jose-pablo-camacho
changed the title
[DO NOT MERGE] fix(routing-key): enable routing key generation in a deterministic way
fix(routing-key): enable routing key generation in a deterministic way
Oct 16, 2024
cgeers
reviewed
Oct 16, 2024
cgeers
approved these changes
Oct 16, 2024
cgeers
reviewed
Oct 16, 2024
ravinadhruve10
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the changes.
jacalvo
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm this fixes the no events issue in the GCP modular onboarding org test. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: https://sysdig.atlassian.net/browse/SSPROD-47456
This PR changes how the
routingKey
value can be generated in a deterministic way based off thecustomerID
andprojectID
using the uuidv5 function within Terraform. This will help avoiding to update the routing key to be updated every time and also avoid leaking resources.It's always going to call the
UpsertRoutingKey
method when storing the component withincloudauth
service.Note:
I was able to run a TFAPPLY
and thenRE-APPLY
it without updating theroutingKey
and without the subsequent errors.