Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(routing-key): enable routing key generation in a deterministic way #44

Merged
merged 5 commits into from
Oct 18, 2024

Conversation

jose-pablo-camacho
Copy link
Contributor

@jose-pablo-camacho jose-pablo-camacho commented Oct 9, 2024

xref: https://sysdig.atlassian.net/browse/SSPROD-47456

This PR changes how the routingKey value can be generated in a deterministic way based off the customerID and projectID using the uuidv5 function within Terraform. This will help avoiding to update the routing key to be updated every time and also avoid leaking resources.

It's always going to call the UpsertRoutingKey method when storing the component within cloudauth service.

Note: I was able to run a TF APPLY and then RE-APPLY it without updating the routingKey and without the subsequent errors.

@jose-pablo-camacho jose-pablo-camacho changed the title [DO NOT MERGE] fix(routing-key): enable routing key generation in a deterministic way fix(routing-key): enable routing key generation in a deterministic way Oct 16, 2024
@jose-pablo-camacho jose-pablo-camacho marked this pull request as ready for review October 16, 2024 09:30
@jose-pablo-camacho jose-pablo-camacho requested a review from a team as a code owner October 16, 2024 09:30
Copy link
Contributor

@ravinadhruve10 ravinadhruve10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the changes.

@jacalvo jacalvo self-requested a review October 18, 2024 14:55
Copy link

@jacalvo jacalvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm this fixes the no events issue in the GCP modular onboarding org test. Thanks!

@jose-pablo-camacho jose-pablo-camacho merged commit 53574df into master Oct 18, 2024
8 checks passed
@jose-pablo-camacho jose-pablo-camacho deleted the fix/routing-key/generation branch October 18, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants