Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cloud-auth-account): ignores data order and removes the ImportStateVerifyIgnore #481

Merged
merged 6 commits into from
Mar 1, 2024

Conversation

wideawakening
Copy link
Contributor

@wideawakening wideawakening commented Feb 19, 2024

test to understand ordering requirement and why are we ignoring it on the ImportStateVerify.
when not adding the ImportStateVerifyIgnore tests fail not because of order, but because we cannot retrieve from the state while setting the state. added a fallback for when no order is available.

if order is important we should add a test to validate that use-case, but not able to reproduce it right now.

@wideawakening wideawakening changed the title fix: ignores data order fix(cloud-auth-account): ignores data order Feb 19, 2024
@wideawakening wideawakening changed the title fix(cloud-auth-account): ignores data order test(cloud-auth-account): ignores data order and removes the ImportStateVerifyIgnore Feb 22, 2024
@wideawakening wideawakening marked this pull request as ready for review February 22, 2024 07:20
@wideawakening wideawakening merged commit 971762b into master Mar 1, 2024
23 checks passed
@wideawakening wideawakening deleted the fix-import-cloud-auth branch March 1, 2024 11:30
@wideawakening
Copy link
Contributor Author

thx @ravinadhruve10 let's see if this topic raises again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants