Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serverless-agent: expose priorities control #483

Merged
merged 3 commits into from
Mar 21, 2024
Merged

serverless-agent: expose priorities control #483

merged 3 commits into from
Mar 21, 2024

Conversation

gnosek
Copy link
Contributor

@gnosek gnosek commented Feb 28, 2024

No description provided.

@gnosek
Copy link
Contributor Author

gnosek commented Feb 28, 2024

The linter failure is not mine

Copy link
Contributor

@pgcrooks-sysdig pgcrooks-sysdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from 2 minors

sysdig/data_source_sysdig_fargate_workload_agent.go Outdated Show resolved Hide resolved
sysdig/data_source_sysdig_fargate_ECS_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@francesco-racciatti francesco-racciatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm apart from the minors Paul highlighted 🙂

Copy link
Contributor

@pgcrooks-sysdig pgcrooks-sysdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gnosek gnosek merged commit 0a79a54 into master Mar 21, 2024
23 checks passed
@gnosek gnosek deleted the priorities branch March 21, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants