Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cloudauth): support accounts with provider partition field #559

Merged
merged 17 commits into from
Nov 8, 2024
Merged

feat(cloudauth): support accounts with provider partition field #559

merged 17 commits into from
Nov 8, 2024

Conversation

ravinadhruve10
Copy link
Contributor

Change summary:

  • Add support for onboarding cloudauth accounts with regulatory framework type
  • Updated cloudauth proto pb.go

@ravinadhruve10
feat(cloudauth): Support accounts with regulatory framework field
d7999c3 
Change summary:
-----------------
- Add support for onboarding cloudauth accounts with regulatory framework type
- Updated cloudauth proto pb.go
@ravinadhruve10 ravinadhruve10 marked this pull request as draft October 4, 2024 06:26
@jose-pablo-camacho jose-pablo-camacho marked this pull request as ready for review October 28, 2024 14:41
ravinadhruve10
ravinadhruve10 commented Oct 30, 2024
View reviewed changes
Copy link
Contributor Author

@ravinadhruve10 ravinadhruve10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, one minor comment.

website/docs/r/secure_cloud_auth_account.md Show resolved Hide resolved
@jose-pablo-camacho jose-pablo-camacho changed the title feat(cloudauth): Support accounts with regulatory framework field feat(cloudauth): support accounts with provider partition field Nov 4, 2024
ravinadhruve10
ravinadhruve10 commented Nov 5, 2024
View reviewed changes
Copy link
Contributor Author

@ravinadhruve10 ravinadhruve10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment, rest LGTM.

sysdig/resource_sysdig_secure_cloud_auth_account.go Show resolved Hide resolved
ravinadhruve10
ravinadhruve10 commented Nov 6, 2024
View reviewed changes
Copy link
Contributor Author

@ravinadhruve10 ravinadhruve10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I was the PR author I can't approve it. But LGTM.

@jose-pablo-camacho jose-pablo-camacho merged commit a10a7c3 into master Nov 8, 2024
23 checks passed
@jose-pablo-camacho jose-pablo-camacho deleted the onboarding-regulation-support branch November 8, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jose-pablo-camacho jose-pablo-camacho jose-pablo-camacho left review comments

@haresh-suresh haresh-suresh haresh-suresh approved these changes

@cgeers cgeers cgeers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ravinadhruve10 @cgeers @haresh-suresh @jose-pablo-camacho