Fix broken symlinks to non existing services #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello - sorry for the late reply. You PR would introduce another bug. If you would disable any service (backup, forget, restore) it would disable the management of each resource (service, file, ...). It would not stop or remove the service. But I have found the bug you have mentioned while testing it.
Edit 1: After some more testing I found the systemd module had a bug, after upgrading to the latest forge version the file has been removed. Please try to upgrade the systemd puppet module and check if this fixes your issue. If not please recreate the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the fact where the module was trying to create systemd services for services that where set to false in the code.
This caused broken symlinks to be created on the machine. Add the if statements resolves this.