Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support last insert id variable @@identity like function LAST_INSERT_ID() #2016

Merged
merged 5 commits into from
Apr 18, 2019

Conversation

ahaha-zhang
Copy link
Contributor

Hi Rene:
I noticed that proxysql has supported to return the correct last_insert_id directly when clients execute built-in function last_insert_id() .#1421.
Thus, there is a consistent behavior between "select @@identity" and "select last_insert_is()" in MySQL. Supporting last-insert-id variable @@identity like function LAST_INSERT_ID() is more applicable and consistent for connection drivers.

@renecannao
Copy link
Contributor

test this please

@pondix
Copy link
Contributor

pondix commented Apr 17, 2019

ok to test

@pondix
Copy link
Contributor

pondix commented Apr 17, 2019

Automated message: PR pending admin approval for build testing

@renecannao renecannao merged commit 3ad5b71 into sysown:v2.0.4 Apr 18, 2019
@renecannao
Copy link
Contributor

Thank you @ahaha-zhang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants