Consolidated PR#4387 & PR#4368: Refactor Makefiles, Build Targets and fixed TAP tests linking #4395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n/proxysql into v2.6.0-more-makefile-fixes
… v2.x_testing_ci_test_failures # Conflicts: # test/tap/tap/Makefile # test/tap/tests/Makefile # test/tap/tests_with_deps/deprecate_eof_support/Makefile
…ize our custom-built OpenSSL library.
…failures # Conflicts: # deps/Makefile # lib/set_parser.cpp
…se) will be initiated. If the C++ standard falls within the range of C++11 up to, but not including, C++17, the build_*_legacy will be activated. ClickHouse targets arenow default build targets. In order to ensure backward compatibility, ClickHouse targets are still available.
…_fixes # Conflicts: # test/tap/tap/Makefile # test/tap/tests/Makefile
…_fixes # Conflicts: # lib/Makefile
rahim-kanji
force-pushed
the
v2.x_unified_makefile_fixes
branch
from
8e473f9
to
282aae7
Compare
rahim-kanji
changed the title
rahim-kanji
changed the title
|
retest this please |
2 similar comments
|
retest this please |
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidated following PRs:
PR#4387
PR#4368
This pull request addresses the following changes:
Build Target Refactoring:
If C++17 is detected, the build_*_default (formerly build_*_clickhouse) will be triggered.
For C++ standards ranging from C++11 up to, but not including, C++17, the build_*_legacy will be activated.
ClickHouse build targets are now default build targets. To maintain backward compatibility, ClickHouse build targets remain accessible.
TAP Test Fixes:
Corrected TAP test linking issues, resolving mismatch in linking OpenSSL and CURL libraries.
Enhancements in Repository Structure: