Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix duplicate item detection issue" #146

Merged
merged 1 commit into from
Nov 11, 2023
Merged

Conversation

eecheng87
Copy link
Collaborator

@eecheng87 eecheng87 commented Nov 11, 2023

@ericlinsechs
Revert this change.

Missing status of is_this_dup makes control flow go inside else statement, then trigger error. (check out trace-06-ops.cmd)
Could you please verify my observation if possible? Thanks.

@eecheng87 eecheng87 requested a review from jserv November 11, 2023 09:49
@jserv jserv merged commit be86d0f into master Nov 11, 2023
4 checks passed
@jserv jserv deleted the revert-145-dedup_bug branch November 11, 2023 09:57
@ericlinsechs
Copy link
Contributor

Hi @eecheng87 ,

Could you please giving more details on why the control flow will go to else if in_this_dup is removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants