Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the computed-goto option #116

Merged
merged 1 commit into from
Mar 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -55,21 +55,6 @@ $(OUT)/syscall_sdl.o: CFLAGS += $(shell sdl2-config --cflags)
LDFLAGS += $(shell sdl2-config --libs)
endif

# Whether to enable computed goto
ENABLE_COMPUTED_GOTO ?= 1
ifeq ($(call has, COMPUTED_GOTO), 1)
ifeq ("$(CC_IS_CLANG)$(CC_IS_GCC)",)
$(warning Computed goto is only supported in clang and gcc.)
override ENABLE_COMPUTED_GOTO := 0
endif
endif
$(call set-feature, COMPUTED_GOTO)
ifeq ($(call has, COMPUTED_GOTO), 1)
ifeq ("$(CC_IS_GCC)", "1")
$(OUT)/emulate.o: CFLAGS += -fno-gcse -fno-crossjumping
endif
endif

ENABLE_GDBSTUB ?= 1
$(call set-feature, GDBSTUB)
ifeq ($(call has, GDBSTUB), 1)
Expand Down
5 changes: 0 additions & 5 deletions src/feature.h
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,6 @@
#define RV32_FEATURE_SDL 1
#endif

/* Use computed goto to accelerate the interpreter */
#ifndef RV32_FEATURE_COMPUTED_GOTO
#define RV32_FEATURE_COMPUTED_GOTO 1
#endif

/* GDB remote debugging */
#ifndef RV32_FEATURE_GDBSTUB
#define RV32_FEATURE_GDBSTUB 1
Expand Down