Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peci: Clear status on completion #368

Merged
merged 1 commit into from
Jun 21, 2023
Merged

peci: Clear status on completion #368

merged 1 commit into from
Jun 21, 2023

Conversation

crawfxrd
Copy link
Member

The PECI-over-eSPI implementation, like the legacy implementation, must acknowledge when the transaction is done by clearing the bit in the register.

Fixes a hang during shutdown on oryp11 after unplugging a TBT display.

TODO:

  • Wait for any pending upstream transactions

The PECI-over-eSPI implementation, like the legacy implementation, must
acknowledge when the transaction is done by clearing the bit in the
register.

Fixes a hang during shutdown on oryp11 after unplugging a TBT display.

Signed-off-by: Tim Crawford <tcrawford@system76.com>
Copy link

@XV-02 XV-02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is resolving the hang I was seeing on both shutdown and reboot. Approving.

@crawfxrd crawfxrd merged commit dd555b9 into master Jun 21, 2023
@crawfxrd crawfxrd deleted the peci-ack branch June 21, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants