kbscan: Increase debounce time from 5ms to 10ms #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some users are reporting that a debounce time of 5ms is not enough to prevent keys from registering twice. Split the difference between the old and the new debounce times and set it to 10ms. Ref: system76/firmware-open#471 Signed-off-by: Tim Crawford <tcrawford@system76.com>
jackpot51
approved these changes
Sep 7, 2023
leviport
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
I have two darp8's set up side-by-side, one with 5ms and the other with 10ms, and I can't tell a difference, even typing ~115wpm on typing tests. I don't think my typing style is one that is affected by the 5ms debounce. It seems to be working though, so I approve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users are reporting that a debounce time of 5ms is not enough to prevent keys from registering twice. Split the difference between the old and the new debounce times and set it to 10ms.
Ref: system76/firmware-open#471