Support second fan without dGPU #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: IT5570E V0.3.2 datasheet; 7.12.3.2 Manual Fan Control Mode Signed-off-by: Tim Crawford <tcrawford@system76.com>
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Have peci_get_temp() return the actual temp instead of the offset, requiring the caller to make another calculation for the temp. Signed-off-by: Tim Crawford <tcrawford@system76.com>
Move the fan-related logic from the PECI and dGPU modules to the fan module. The PECI and dGPU modules are now only responsible for reading the thermal data, and the fan module handles calculating and updating the fans duties based on that data.
darp10 demonstrates that a board without a dGPU may still have a second fan, so rename the CPU (PECI) fan to FAN1 and dGPU fan to FAN2. Signed-off-by: Tim Crawford <tcrawford@system76.com>
This was referenced Jul 5, 2024
jackpot51
previously approved these changes
Jul 5, 2024
This was referenced Jul 5, 2024
Replace hard-coded PWM channels with defines so the second fan on darp10 can be handled like the second fan on units with a dGPU. Signed-off-by: Tim Crawford <tcrawford@system76.com>
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Fully support fan points for the second fan on darp10. Signed-off-by: Tim Crawford <tcrawford@system76.com>
Thermal properties of each model differ and they should not rely on an arbitrary, unoptimized set of fan points. It is one thing to copy the points from the previous generation for a model, as a lot of the time the chassis design is nearly identical, but it should be always be explicit. Signed-off-by: Tim Crawford <tcrawford@system76.com>
jackpot51
approved these changes
Jul 15, 2024
|
With this PR, how should ectool report fan speeds? Looking at a gaze16-3060-b as the dGPU system, it looked like ectool reported fan speed as an 8-bit value between 0 and 255 (inclusive). |
|
|
XV-02
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behavioral changes:
Test on:
Requires: system76/coreboot#222
Includes: #454, #456, #457, #481
Unblocks: #390