Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a moving average for temperatures #482

Closed
wants to merge 1 commit into from
Closed

Use a moving average for temperatures #482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/board/system76/common/dgpu.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@

int16_t dgpu_temp = 0;

// Update interval is 250ms, so average over 1s period
static int16_t dgpu_temps[4] = { 0 };

void dgpu_init(void) {
// Set up for i2c usage
i2c_reset(&I2C_DGPU, true);
Expand All @@ -33,11 +36,18 @@ bool dgpu_get_temp(int16_t *const data) {
}

void dgpu_read_temp(void) {
dgpu_temps[0] = dgpu_temps[1];
dgpu_temps[1] = dgpu_temps[2];
dgpu_temps[2] = dgpu_temps[3];

if (power_state == POWER_STATE_S0) {
if (dgpu_get_temp(&dgpu_temp)) {
return;
if (!dgpu_get_temp(&dgpu_temps[3])) {
dgpu_temps[3] = 0;
}
} else {
dgpu_temps[3] = 0;
}

dgpu_temp = 0;
dgpu_temp = (dgpu_temps[0] + dgpu_temps[1] + dgpu_temps[2] + dgpu_temps[3]) /
ARRAY_SIZE(dgpu_temps);
}
16 changes: 13 additions & 3 deletions src/board/system76/common/peci.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@
bool peci_on = false;
int16_t peci_temp = 0;

// Update interval is 250ms, so average over 1s period
static int16_t peci_temps[4] = { 0 };

// Tjunction = 100C for i7-8565U (and probably the same for all WHL-U)
#define T_JUNCTION ((int16_t)100)

Expand Down Expand Up @@ -382,12 +385,19 @@ int16_t peci_wr_pkg_config(uint8_t index, uint16_t param, uint32_t data) {
#endif // CONFIG_PECI_OVER_ESPI

void peci_read_temp(void) {
peci_temps[0] = peci_temps[1];
peci_temps[1] = peci_temps[2];
peci_temps[2] = peci_temps[3];

peci_on = peci_available();
if (peci_on) {
if (peci_get_temp(&peci_temp)) {
return;
if (!peci_get_temp(&peci_temps[3])) {
peci_temps[3] = 0;
}
} else {
peci_temps[3] = 0;
}

peci_temp = 0;
peci_temp = (peci_temps[0] + peci_temps[1] + peci_temps[2] + peci_temps[3]) /
ARRAY_SIZE(peci_temps);
}
Loading