Use dynamic bbox to prevent clipping of edges passing tile border

systemed · May 4, 2021 · 309a312 · 309a312
1 parent 244614b
commit 309a312
Show file tree

Hide file tree

Showing 3 changed files with 84 additions and 16 deletions.
diff --git a/include/coordinates.h b/include/coordinates.h
@@ -185,6 +185,7 @@ class TileBbox {
 
 	std::pair<int,int> scaleLatpLon(double latp, double lon) const;
 	Box getTileBox() const;
+	Box getExtendBox() const;
 };
 
 #endif //_COORDINATES_H

diff --git a/src/coordinates.cpp b/src/coordinates.cpp
@@ -97,3 +97,9 @@ Box TileBbox::getTileBox() const {
 	return Box(geom::make<Point>(minLon+xmargin, minLatp+ymargin), geom::make<Point>(maxLon-xmargin, maxLatp-ymargin));
 }
 
+Box TileBbox::getExtendBox() const {
+	return Box(
+    	geom::make<Point>( minLon-(maxLon-minLon)*2.0, minLatp-(maxLatp-minLatp)*(8191.0/8192.0)), 
+		geom::make<Point>( maxLon+(maxLon-minLon)*(8191.0/8192.0), maxLatp+(maxLatp-minLatp)*2.0));
+}
+
diff --git a/src/output_object.cpp b/src/output_object.cpp
@@ -80,29 +80,90 @@ Geometry buildWayGeometry(OSMStore &osmStore, OutputObject const &oo, const Tile
 
 		case OutputGeometryType::LINESTRING:
 		{
-			MultiLinestring out;
-			geom::intersection(osmStore.retrieve<mmap::linestring_t>(oo.handle), bbox.clippingBox, out);
-			return out;
+			auto const &ls = osmStore.retrieve<mmap::linestring_t>(oo.handle);
+
+			Box box = bbox.clippingBox;
+			for(size_t i = 0; i < ls.size() - 1; ++i) {
+				Point p1 = ls[i];
+				Point p2 = ls[i + 1];
+
+				if(geom::within(p1, bbox.clippingBox) != geom::within(p2, bbox.clippingBox)) {
+					box.min_corner() = Point(	
+						std::min(box.min_corner().x(), std::min(p1.x(), p2.x())), 
+						std::min(box.min_corner().y(), std::min(p1.y(), p2.y())));
+					box.max_corner() = Point(	
+						std::max(box.max_corner().x(), std::max(p1.x(), p2.x())), 
+						std::max(box.max_corner().y(), std::max(p1.y(), p2.y())));
+				}
+			}
+
+			Box extBox = bbox.getExtendBox();
+			box.min_corner() = Point(	
+				std::max(box.min_corner().x(), extBox.min_corner().x()), 
+				std::max(box.min_corner().y(), extBox.min_corner().y()));
+			box.max_corner() = Point(	
+				std::min(box.max_corner().x(), extBox.max_corner().x()), 
+				std::min(box.max_corner().y(), extBox.max_corner().y()));
+
+			MultiLinestring result;
+			geom::intersection(ls, box, result);
+			return result;
 		}
 
 		case OutputGeometryType::POLYGON:
 		{
-			auto const &mp = osmStore.retrieve<mmap::multi_polygon_t>(oo.handle);
-
-			Polygon clippingPolygon;
-
-			geom::convert(bbox.clippingBox, clippingPolygon);
-			if (!geom::intersects(mp, clippingPolygon)) { return MultiPolygon(); }
-			if (geom::within(mp, clippingPolygon)) { 
-				MultiPolygon out;
-				boost::geometry::assign(out, mp);
-				return out; 
+			auto const &input = osmStore.retrieve<mmap::multi_polygon_t>(oo.handle);
+
+			Box box = bbox.clippingBox;
+
+			for(auto const &p: input) {
+				for(auto const &inner: p.inners) {
+					for(std::size_t i = 0; i < inner.size() - 1; ++i) 
+					{
+						Point p1 = inner[i];
+						Point p2 = inner[i + 1];
+
+						if(geom::within(p1, bbox.clippingBox) != geom::within(p2, bbox.clippingBox)) {
+							box.min_corner() = Point(	
+								std::min(box.min_corner().x(), std::min(p1.x(), p2.x())), 
+								std::min(box.min_corner().y(), std::min(p1.y(), p2.y())));
+							box.max_corner() = Point(	
+								std::max(box.max_corner().x(), std::max(p1.x(), p2.x())), 
+								std::max(box.max_corner().y(), std::max(p1.y(), p2.y())));
+						}
+					}
+				}
+
+				for(std::size_t i = 0; i < p.outer.size() - 1; ++i) {
+					Point p1 = p.outer[i];
+					Point p2 = p.outer[i + 1];
+
+					if(geom::within(p1, bbox.clippingBox) != geom::within(p2, bbox.clippingBox)) {
+						box.min_corner() = Point(	
+							std::min(box.min_corner().x(), std::min(p1.x(), p2.x())), 
+							std::min(box.min_corner().y(), std::min(p1.y(), p2.y())));
+						box.max_corner() = Point(	
+							std::max(box.max_corner().x(), std::max(p1.x(), p2.x())), 
+							std::max(box.max_corner().y(), std::max(p1.y(), p2.y())));
+					}
+				}
 			}
 
+			Box extBox = bbox.getExtendBox();
+			box.min_corner() = Point(	
+				std::max(box.min_corner().x(), extBox.min_corner().x()), 
+				std::max(box.min_corner().y(), extBox.min_corner().y()));
+			box.max_corner() = Point(	
+				std::min(box.max_corner().x(), extBox.max_corner().x()), 
+				std::min(box.max_corner().y(), extBox.max_corner().y()));
+
+			Polygon clippingPolygon;
+			geom::convert(box, clippingPolygon);
+
 			try {
-				MultiPolygon out;
-				geom::intersection(mp, clippingPolygon, out);
-				return out;
+				MultiPolygon mp;
+				geom::intersection(input, clippingPolygon, mp);
+				return mp;
 			} catch (geom::overlay_invalid_input_exception &err) {
 				std::cout << "Couldn't clip polygon (self-intersection)" << std::endl;
 				return MultiPolygon(); // blank