fix weird Stack rendering issue #2868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent in built version of the app
theoephraim
commented
Oct 16, 2023
| @@ -13,6 +13,7 @@ | |||
| <br /> | |||
| workspace settings (gear in top right) > "Import Workspace" | |||
| </p> | |||
| <VButton icon="check" @click="close">Close this window</VButton> | |||
There was a problem hiding this comment.
undoing zack's changes that were just a workaround for the issue
theoephraim
commented
Oct 16, 2023
| async function continueHandler() { | ||
| await moduleStore.EXPORT_WORKSPACE(); | ||
| function continueHandler() { | ||
| moduleStore.EXPORT_WORKSPACE(); |
There was a problem hiding this comment.
will re-enable the no floating promises eslint rule soon, but unrelated to this, so leaving it as is to match other similar uses of api actions.
theoephraim
commented
Oct 16, 2023
|
|
||
| // NOTE - ran into a weird errors that only appeared on the built version of the app | ||
| // but resolved it by adding this Fragment wrapper around each child | ||
| wrappedChildren.push(h(Fragment, {}, [children[i]])); |
There was a problem hiding this comment.
this Fragment wrapper is the magic that fixed it... Got the idea from vuejs/core#8298 but never was fully able to wrap my head around what exactly is triggering the issue.
theoephraim
commented
Oct 16, 2023
| const children = [] as VNode[]; | ||
| rawChildren.forEach((child) => { | ||
| // components that are hidden via v-if end up as a Comment <!--v-if--> so we skip over them | ||
| if (child.type === Comment) return; | ||
|
|
||
| // if the child is a template with a v-for, we actually want to get all of its children | ||
| if (child.type === Fragment) { | ||
| children.push(...(child.children as VNode[])); | ||
| children.push(...unwrapChildren(child.children as VNode[])); |
There was a problem hiding this comment.
this recursive unwrapping is something I realized was missing to handle nested loops and templates
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
very odd issue only visible when running the built version of the app where some children of
Stackwere not being re-rendered. I didn't manage to get a minimal reproduction put together, but I was eventually able to get it fixed 🤷