Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filtering when using a smart group #30

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

seamuslee001
Copy link
Contributor

I was testing this extension with a client site what I found was that when I was using a smart group as the include group it is possible that results weren't able to found because it was joining to the wrong table.

civicrm_group_contact is used for static group and manually added contacts to groups. However when the smart group cache is populated those contacts are also added to the cache table. The cache table also doesn't have a status field as it is limited to just contacts that are in the group

Also I know of at least one site that has dropped the id auto increment column from the cache tables so this handles that situation as well.

Copy link
Member

@bjendres bjendres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bjendres bjendres merged commit ac2d83e into systopia:master Mar 5, 2024
@bjendres
Copy link
Member

bjendres commented Mar 5, 2024

Thanks @seamuslee001, I created a new beta release (https://github.com/systopia/de.systopia.xdedupe/releases/tag/1.2-beta2). If you give me a shout in a couple if days/weeks if it's working, I'll (finally) release a 1.2.0.

@bjendres bjendres added bug Something isn't working enhancement New feature or request labels Oct 30, 2024
@bjendres bjendres added this to the 1.2 milestone Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants