Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating DataURI for image inlining #31

Closed

Conversation

niko-dunixi
Copy link
Contributor

Should solve the issue for this preprocesssor and create a better
user-experience. Also enables other downstream renderers to work
agnostically and not only the html renderer.

Should solve the issue for this preprocesssor and create a better
user-experience. Also enables other downstream renderers to work
agnostically and not only the html renderer.

- rust-lang/mdBook#1087
@niko-dunixi
Copy link
Contributor Author

The one thing I was not really able to fully test and what I'd like some guidance on, is how we can test the text/plain as an image src. From what I can tell the text/plain is a fully valid data uri option
image

What I don't know if it will embed as I expect when placed into an image tag.

Currently I'm not sure how you get plantuml to generate text instead of an svg. Perhaps there is a bug, but using plantuml,txt instead of just plain plantuml didn't actually generate text output.

I can revert to the original method already in use for embedding text if this doesn't actually work as expected, but I just need to know how to generate those text documents.

@niko-dunixi
Copy link
Contributor Author

AH! It was my mistake. I somehow read plantuml,txt instead of plantuml,format=txt. I'll restore that branch of functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant