Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating DataURI for image inlining #32

Merged

Conversation

niko-dunixi
Copy link
Contributor

Should solve the issue for this preprocesssor and create a better
user-experience. Also enables other downstream renderers to work
agnostically and not only the html renderer. Can convert text files to
data-uri but will still defer to the original text embedding method to
preserve historical functionality

Should solve the issue for this preprocesssor and create a better
user-experience. Also enables other downstream renderers to work
agnostically and not only the html renderer. Can convert text files to
data-uri but will still defer to the original text embedding method to
preserve historical functionality

- rust-lang/mdBook#1087
@sytsereitsma
Copy link
Owner

Thanks! This was on my list too. I don't often have time to look at the PRs here, so bear with me if my responses take a while.
That said I'd prefer the data URIs to be an optional output format. I think a TOML config flag would be nice for this. Reason being data URIs are quite an arcane thing (at least to me) and I'd like to keep support for regular image generation.

Can you make that work?

@niko-dunixi
Copy link
Contributor Author

Hello, @sytsereitsma! I can probably get that working, but I'm not sure what my bandwidth will be these next couple sprints. I'll try to squeeze that in. If you want, we could create a feature branch and make this a work-in-progress to eventually get merged into master so it can be incrementally worked on, but also still be co-located in the same repository. That's your call though

@sytsereitsma
Copy link
Owner

It's a feature branch now isn't it 😉
Just push your changes to it whenever you can find time.

I'll convert the PR to a draft

@sytsereitsma sytsereitsma marked this pull request as draft March 9, 2022 20:05
@sytsereitsma sytsereitsma changed the base branch from master to datauri_support July 4, 2022 07:49
@sytsereitsma sytsereitsma marked this pull request as ready for review July 4, 2022 07:50
@sytsereitsma sytsereitsma merged commit 32175e3 into sytsereitsma:datauri_support Jul 4, 2022
@sytsereitsma
Copy link
Owner

Hi Paul,
Added the configurable bit myself. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants