default expiry of never selected in dropdown when passed as env var #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I reverted the option grouping, it is important to visually set the never option apart from the expire after options. Otherwise good fix, thanks for your contribution! :-) |
|
Would it be possible to make a 1.2.2 release for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended the if statement to set a selected value for never. This resolves issue MICROBIN_DEFAULT_EXPIRY=never does not update selected value in option Expiration Dropdown #127
Refactored to include the Never Expire inline with the other options in the Dropdown.
Previous dropdown style:
After refactor:
