Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROIPooling v2 #17

Merged
merged 1 commit into from
Dec 17, 2015
Merged

ROIPooling v2 #17

merged 1 commit into from
Dec 17, 2015

Conversation

szagoruyko
Copy link
Owner

This fixes bugs in ROIPooling of Ross's FastRCNN code. Thanks to @adamlerer for fixing!

Changes:

  • bounding box was always shrinked 16 pixels width and height
  • x1,y1,x2,y2 in feature map scale were computed with floor and ceil so depending on a small shift it could be resized.
  • new atomic backward is 50x faster. nondeterministic.

fmassa
fmassa reviewed Dec 3, 2015
View reviewed changes
ROIPooling.lua
self.gradInput_boxes = self.gradInput_boxes or data.new()
self.gradInput_rois = self.gradInput_rois or data.new()

C.inn_ROIPooling_updateGradInput(cutorch.getState(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should change this to be updateGradInputAtomic, or add the previous non-atomic version as v1 ;)

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Francisco, updated. I am about to add a gradient test

@szagoruyko
Copy link
Owner Author

adding gradient test by @0wu

szagoruyko added a commit that referenced this pull request Dec 17, 2015
@szagoruyko
Merge pull request #17 from szagoruyko/roipoolingv2
e6a65cb 
ROIPooling v2
@szagoruyko szagoruyko merged commit e6a65cb into master Dec 17, 2015
@szagoruyko szagoruyko deleted the roipoolingv2 branch December 17, 2015 14:45
This was referenced Dec 17, 2015
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szagoruyko @fmassa