Release 2.0.0

[szepeviktor]

What does it take to release 2.0.0?
Do we have v1-only features?
What is lost in v2?

phpstan-wordpress/composer.json

Line 15 in 3ffad20

"php-stubs/wordpress-stubs": "^6.6.2",

[IanDelMar]

• v2 drops support for:

  • PHPStan 1.x (see PHPStan 2.0 support #243),
  • PHP 7.2 (see PHPStan 2.0 support #243), and
  • php-stubs/wordpress-stubs 6.6.1 and below (see WIP: Move several extensions to WP stubs #235; dynamic return type extensions have been moved to php-stubs/wordpress-stubs).

• Some dynamic return type extensions have been removed but were not moved to php-stubs/wordpress-stubs because they were either incorrect or indeterminable due to filterable arguments (see WIP: Move several extensions to WP stubs #235).

• SzepeViktor\PHPStan\WordPress\HookDocsParamException has been removed, as it was no longer in use (see WIP: Move several extensions to WP stubs #235).

• StringOrArrayDynamicFunctionReturnTypeExtension has been renamed to EscSqlDynamicFunctionReturnTypeExtension (see Rename StringOrArray extension for clarity #237).

• Some early terminating calls have been moved to php-stubs/wordpress-stubs (see Remove early terminating calls covered in stubs #238).

v1-only is support for PHP 7.2 and below, PHPStan below 2.x, older versions of WP(stubs), and dynamic return type extensions for functions with filterable arguments that were not transferred. (I am not certain whether the incorrect ones were fixed in v1 as well; I’ll verify this over the next few days).

I think it would be best to resolve the _get_list_table() issue (php-stubs/wordpress-stubs#257) before releasing 2.0.0.

[LeTraceurSnork]

Could you please sync versions with PHPStan original package starting from v2 please? I mean, its a bit unhandy that PHPStan last v1 minor is 1.12 while this package is 1.3, it's a bit confusing

[szepeviktor]

Could you please sync versions with PHPStan original package

Vote time!

[IanDelMar]

While I completely understand @LeTraceurSnork's point, halting progress on szepeviktor/phpstan-wordpress until PHPStan advances may not be in the best interests of the contributors and users. Any new feature, such as a return type extension, qualifies for a minor release, meaning we would need to wait for PHPStan’s next minor update. Fixes for extensions should be released as patches, but we would be unable to do so until PHPStan issues its next patch, minor, or even major release. Ultimately, semantic versioning becomes pointless for szepeviktor/phpstan-wordpress. After all, one look at the composer.json file tells you which PHPStan versions are applicable to the given version of szepeviktor/phpstan-wordpress.

[LeTraceurSnork]

What about extended semver like X.Y.Z.P, where P is suffix for your own version, and Z - is latest patch of parent package

[szepeviktor]

@LeTraceurSnork All I can promise you is when I see a Merge button I click on it.
It would be great not to be restricted by PHPStan's development.
Have you seen other extensions' release versions?

[IanDelMar]

What about extended semver like X.Y.Z.P, where P is suffix for your own version, and Z - is latest patch of parent package

Unless we immediately drop support for older versions of PHPStan right after a release (don't go breaking Viktor's heart 🙏), I think this will create more confusion than it resolves. If X.Y.Z is always the latest version, others will not only have to check whether older versions are supported (which they already need to do), but it also gives the false impression that szepeviktor/phpstan-wordpress is somehow bound to X.Y.Z, which is not the case.

[LeTraceurSnork]

Ok, suggestion withdrawn 🙈

[szepeviktor]

Jump into the empty pool: https://github.com/szepeviktor/phpstan-wordpress/releases/tag/v2.0.0-rc.1