-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Move several extensions to WP stubs #235
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All right. |
Although it may not seem like it, there isn't actually much to review. This PR removes some of the extensions that have been ported to WP stubs. The remainder is simply an import of recent changes (from the last two months) in the master branch. |
Merged
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request syncs the 2.x branch with the master branch and removes extensions whose functionality has already been implemented or is about to be implemented by php-stubs/wordpress-stubs, or is no longer needed or is incorrect:
EchoKeyDynamicFunctionReturnTypeExtension
GetApprovedCommentsDynamicFunctionReturnTypeExtension
GetListTableDynamicFunctionReturnTypeExtension
GetPostDynamicFunctionReturnTypeExtension
GetPostsDynamicFunctionReturnTypeExtension
GetSitesDynamicFunctionReturnTypeExtension
GetTermsDynamicFunctionReturnTypeExtension
WpDieDynamicFunctionReturnTypeExtension
WpThemeMagicPropertiesClassReflectionExtension
EchoKeyDynamicFunctionReturnTypeExtension
the_title_attribute()
,wp_dropdown_languages()
,wp_get_archives()
,wp_list_bookmarks()
,wp_list_categories()
, andwp_list_pages()
have been transferred to php-stubs/wordpress-stubs.wp_dropdown_categories()
,wp_dropdown_pages()
,wp_dropdown_users()
, andwp_link_pages()
always return a string as documented, and hence are not included in any PR porting functionality to php-stubs/wordpress-stubs.$args
parameter ofget_search_form()
,wp_list_authors()
,wp_list_comments()
,wp_list_users()
,wp_login_form()
, andwp_page_menu()
is filterable, and thus the value of$args['echo']
is unknown. Therefore, these were excluded from the functionality ported to php-stubs/wordpress-stubs.RedirectCanonicalDynamicFunctionReturnTypeExtension
Starting from PHPStan 1.10.49, void types, including void in unions, are transformed into null. This extension is no longer needed.
Related
PRs implementing the functionality in php-stubs/wordpress-stubs
To Do
EchoKeyDynamicFunctionReturnTypeExtension
can be implemented in WP stubsGetListTableDynamicFunctionReturnTypeExtension
can be implemented in WP stubsGetPostDynamicFunctionReturnTypeExtension
can be implemented in WP stubsRedirectCanonicalDynamicFunctionReturnTypeExtension
can be implemented in WP stubsShortcodeAttsDynamicFunctionReturnTypeExtension
can be implemented in WP stubsStringOrArrayDynamicFunctionReturnTypeExtension
can be implemented in WP stubsWpDieDynamicFunctionReturnTypeExtension
can be implemented in WP stubsWpThemeMagicPropertiesClassReflectionExtension
can be implemented in WP stubsphp-stubs/wordpress-stubs
version incomposer.json
to the first released version that includes all the functionality of the removed extensions