Update client to use BearerTokenFile when needed
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
| @@ -83,6 +87,21 @@ func CreateUnified() (Interface, error) { | |||
| return client, nil | |||
| } | |||
|
|
|||
| // CreateUnified returns the unified client | |||
| func CreateUnifiedWithOptions(opts *Options) (Interface, error) { | |||
There was a problem hiding this comment.
Is it possible to create client via CreateUnified() and then modify its rest.Config?
There was a problem hiding this comment.
Alternatively we can also consider using functional options, see https://golang.cafe/blog/golang-functional-options-pattern.html
There was a problem hiding this comment.
no, it returns the clientset at this level we only can call resources.
Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
szuecs
reviewed
Oct 4, 2023
| if err != nil { | ||
| log.Fatalf("Failed to create unified RouteGroup client: %v", err) | ||
| } | ||
| log.Println("have cli") | ||
|
|
||
| // example kubernetes.Interface access | ||
| ings, err := cli.ExtensionsV1beta1().Ingresses("").List(context.TODO(), metav1.ListOptions{}) | ||
| //ings, err := cli.NetworkingV1().Ingress("").List(context.TODO(), metav1.ListOptions{}) | ||
| // ings, err := cli.ExtensionsV1beta1().Ingresses("").List(context.TODO(), metav1.ListOptions{}) |
szuecs
reviewed
Oct 4, 2023
| @@ -12,17 +12,22 @@ import ( | |||
| ) | |||
|
|
|||
| func main() { | |||
| cli, err := rgclient.CreateUnified() | |||
| cli, err := rgclient.CreateUnifiedWithOptions(&rgclient.Options{TokenFile: "/tmp/k8s_token"}) | |||
| // cli, err := rgclient.CreateUnified() | |||
szuecs
reviewed
Oct 4, 2023
| @@ -12,17 +12,22 @@ import ( | |||
| ) | |||
|
|
|||
| func main() { | |||
| cli, err := rgclient.CreateUnified() | |||
| cli, err := rgclient.CreateUnifiedWithOptions(&rgclient.Options{TokenFile: "/tmp/k8s_token"}) | |||
There was a problem hiding this comment.
I guess you want to specify a const for this and I don't see how a fixed file can help in a test as you need to write the valid token into the file somehow
|
Closing this since it could be resolved by using the right loadingRules := clientcmd.NewDefaultClientConfigLoadingRules()
configOverrides := &clientcmd.ConfigOverrides{}
kubeConfig := clientcmd.NewNonInteractiveDeferredLoadingClientConfig(loadingRules, configOverrides)
config, err := kubeConfig.ClientConfig()
# error handling
client, err := rgclient.NewClientset(kubeConfig)
# error handling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we should be able to lunch the client with different Options or none, it tries to resemble zalando/skipper#2590 so requests could be authorized with tokens outside clusters.
Without this PR I get
2023/10/04 17:55:21 Failed to get Ingress list: Unauthorizedin the example, could hack around and try to use/var/run/secrets/kubernetes.io/serviceaccount/tokenbut this also didn't work