Unfold vCard before parsing #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves regular expression compilation out into a wrapper function that handles errors, so that we can add additional regular expression usage without exploding the code.
andy-bower
force-pushed
the
unfold-vcard
branch
from
7dcf49b to
688bf33
Compare
Follow the RFC by unfolding folded vCard lines (CRLF WSP) before using the vCard. This is done in place as we will be accessing all the data immediately anyway as we pass the automata over it so it is likely to stay in cache. This pipelined approach seems easier than special handling of continuation lines and follows the spirit of the specification.
andy-bower
force-pushed
the
unfold-vcard
branch
from
688bf33 to
ec848bc
Compare
andy-bower
commented
Dec 12, 2024
| /** | ||
| * Compile regex, checking and handling errors. | ||
| * | ||
| * \parm[in] preg The compiled regex. |
There was a problem hiding this comment.
I guess the doxygen should be out, not in for this parameter!
By the way, have you ever attempted a doxygen run over this source? I haven't!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38 by unfolding vCard as per RFC before parsing it. This makes
mcdsusable for convenient command line queries of postal addresses which would otherwise be truncated.This pipelined approach seems to be a simpler solution than building continuation handing into the main parser. There are other ways in which the parse could be enhanced but it would probably still be easier to do the unfolding as a separate step, like this.
Example: