Copes with responseText getting returned for xml rather than responseXml #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umq
pushed a commit
to umq/magicxml
that referenced
this pull request
Feb 8, 2018
Microsoft Edge returns null when Content-Type does not suit see also: t-davies#5
umq
pushed a commit
to umq/magicxml
that referenced
this pull request
Feb 8, 2018
Microsoft Edge returns null when Content-Type does not suit see also: t-davies#5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi I was using TinyWeb for some reason this returns an xml file as application/xml rather than text/xml
This means response.xhr is null
So I made a little mod whereby if responseXml is null it loads up responseText instead
(works in internet explorer even without this mod but not in chrome + firefox)