-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boa noite #7
Open
diogorg
wants to merge
51
commits into
t10d:master
Choose a base branch
from
diogorg:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Boa noite #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pessoal da T10, boa noite. Como estão?
Agradeço muito a oportunidade de criar esta pequena aplicação.
Fiz de coração e pelo desafio/diversão.
Caprichei contudo há muitos pontos de melhoria.
Vou depois expandir alguns pontos. Identificar outros padrões de cartas do Poker eu acho que é uma estratégia bem legal.
Permitir criar a lista de cartas de forma aleatória.
User o local storage para manter o visual das cartas e as opções selecionados pelo usuário.
Acredito que só vi depois que não era para usar um framework CSS. Usei o Material-ui não porque estou acostumado, mas justamente pelo contrário, para aprender ele.
Mudei a forma de salvar na API. Colocando as cartas lá, mas o pivot deixei na URL. O que é interessante para testar uma mesma configuração e mudar o pivot dinamicamente.
A parte de testes esta crú. Vou melhorar este ponto também. Há diversos pontos do software que tenho certeza que posso fazer melhor e de forma mais performática.
Anyway. Um bom final de semana para vocês. Vou subir a aplicação para testar rodando e depois coloco o link.
Um super abraço, fiquem com Deus.