Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basque locale #529

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Added basque locale #529

merged 2 commits into from
Mar 5, 2024

Conversation

ikerib
Copy link
Contributor

@ikerib ikerib commented Mar 3, 2023

No description provided.

@vercel
Copy link

vercel bot commented Mar 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
air-datepicker ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 7, 2023 at 2:59PM (UTC)

Copy link
Owner

@t1m0n t1m0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ikerib Hi, thanks for the contribution, I've left some comments.

src/locale/eu.js Outdated
Comment on lines 1 to 19
"use strict";

Object.defineProperty(exports, "__esModule", {
value: true
});
exports.default = void 0;
var _default = {
days: ['Igandea', 'Astelehena', 'Asteartea', 'Asteazkena', 'Osteguna', 'Ostirala', 'Larunbata'],
daysShort: ['Iga', 'Ast', 'Asr', 'Asz', 'Ost', 'Osr', 'Lar'],
daysMin: ['Ig', 'As', 'Ar', 'Az', 'Os', 'Or', 'La'],
months: ['Urtarrila', 'Otsaila', 'Martxoa', 'Apirila', 'Maiatza', 'Ekaina', 'Uztaila', 'Abuztua', 'Iraila', 'Urria', 'Azaroa', 'Abendua'],
monthsShort: ['Urt', 'Ots', 'Mar', 'Api', 'Mai', 'Eka', 'Uzt', 'Abu', 'Ira', 'Urr', 'Aza', 'Abe'],
today: 'Gaur',
clear: 'Garbitu',
dateFormat: 'dd/MM/yyyy',
timeFormat: 'hh:mm aa',
firstDay: 1
};
exports.default = _default;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like a distributable code, please see format of source code of locale files - https://github.com/t1m0n/air-datepicker/blob/v3/src/locale/en.js

Comment on lines 1 to 6
declare module 'air-datepicker/locale/eu' {
import {AirDatepickerLocale} from 'air-datepicker';
const eu: AirDatepickerLocale;

export default eu;
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to add typings in source code, its generated automatically with compilation. It should be removed, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants