Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource list Enhancement #959

Merged
merged 7 commits into from
Oct 6, 2024
Merged

Resource list Enhancement #959

merged 7 commits into from
Oct 6, 2024

Conversation

Maximus7474
Copy link
Contributor

Small refactor for the resource list, altered it so that each category is collapsible making it easier to navigate them.

image

The categories hide correctly when using the Default Resources and Started resource sliders.

I decided to alter the css style for the card to remove the blue highlight on top as it didn't look great.

@tabarra
Copy link
Owner

tabarra commented Sep 29, 2024

Thanks for the PR! Do you mind making some adjustments?

  1. Drop fontawesome, you can just use the classes icon-arrow-down (to show) and icon-arrow-up (to hide). With font-size: 75%; font-weight: bold; I think it will look good.
  2. Move the chevrons to the right.
  3. For some reason there is some border radius not being respected in the table head, idk where the issue is.
  4. Add a show all / collapse all button to the top of the page, near the filter buttons.

@tabarra tabarra added the Pending Changes Pending Changes label Sep 29, 2024
@Maximus7474
Copy link
Contributor Author

Maximus7474 commented Sep 30, 2024

Hi Tabarra,

Will look into that ;)

@Maximus7474
Copy link
Contributor Author

Sorry to bother, seems like either I've set something up incorrectly or something has changed which I didn't account for.
Any suggestions ?
image

@tabarra
Copy link
Owner

tabarra commented Sep 30, 2024

Try deleting all node_modules folder, then running a single npm i from the root directory.

@Maximus7474
Copy link
Contributor Author

Yeah, I F ed up when creating my dev env

@Maximus7474
Copy link
Contributor Author

Sorry again, globals are undefined when launching it, just sticks in the awaitHttp promise inside of core/extras/banner.js

@tabarra
Copy link
Owner

tabarra commented Sep 30, 2024

Can you join https://discord.gg/txAdmin and ping me in the offtopic channel so I can help you?

@Maximus7474
Copy link
Contributor Author

Chevrons set to the right and using the suggested style changes
image

@Maximus7474
Copy link
Contributor Author

Added the switch
image
Thought this was the best approach

@tabarra
Copy link
Owner

tabarra commented Oct 6, 2024

I changed the UI and implementation a little bit.
image

@tabarra tabarra merged commit 8fea48a into tabarra:develop Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Pending Changes Pending Changes ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants