Customize unicorn command #32
Conversation
Lets you customize unicorn command to something other than `bundle exec unicorn`, for example `bin/unicorn`. Also includes minor updates such as using `current_path.join` instead of `File.join`.
|
Humm, I just rejected PR #28 because changing the command changes the meaning of the arguments particularly for -E when using unicorn vs unicorn_rails. I do see the value of being able to specify ./bin/unicorn though and I'm guessing you use binstubs. My major concern with this change is that it will likely break the SSHKit::CommandMap. See the tl;dr here: https://github.com/capistrano/capistrano. Are the updates for current_path.join just a syntax preference or was there any other motivation? |
According to https://github.com/capistrano/capistrano#tasks, commands with spaces gets executed slightly differently. To preserve 'better' behaviour, use splat operator for the first argument to `execute` and make default contain array of command chunks. It is perfectly fine to set `unicorn_command` to just 'bin/unicorn', splat can handle that.
|
Thanks for pointing this out, I wan't aware of this behaviour. Could you please take a look at the second commit I have just pushed? It should preserve original behavior and let users customize how they want to run unicorn at their own peril. In re |
|
I am favorable towards this. |
|
Would like to use Rainbows! with this, +1 |
|
I would like this as well. Hacking around it in the mean time. |
Lets you customize unicorn command to something other than
bundle exec unicorn, for examplebin/unicorn.Also includes minor updates such as using
current_path.joininstead ofFile.join.