Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): asm functions #1061

Merged
merged 26 commits into from
Dec 20, 2024
Merged

feat(docs): asm functions #1061

merged 26 commits into from
Dec 20, 2024

Conversation

novusnota
Copy link
Member

Rewrote the method ID collisions section to remove all logical jumps and make it much more streamlined :)

Also adjusted the structure a little towards the upcoming PR revamping this page. I'll push the draft of it right after we deal with asm functions here.

P.S.: I actually call argument to return position mappings "arrangements" and not "shuffle" as in grammar.ohm, because the latter kinda implies randomness, while those are actually deterministic. Hence, "asm arrangments".

Issue

Also, resolved two teeny tiny issues from tact-docs — virtually 3-5 lines of fixes for each, no need in a separate CHANGELOG entry:

Checklist

  • I have updated CHANGELOG.md
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@novusnota novusnota added this to the v1.6.0 milestone Nov 19, 2024
@novusnota novusnota requested a review from a team as a code owner November 19, 2024 02:22
@novusnota novusnota changed the title feat(docs): asm-functions feat(docs): asm functions Nov 19, 2024
docs/src/content/docs/book/functions.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/book/functions.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/book/functions.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/book/import.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/book/functions.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/book/functions.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/book/functions.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/book/functions.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/book/functions.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/book/functions.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/book/functions.mdx Outdated Show resolved Hide resolved
@anton-trunov anton-trunov self-assigned this Nov 20, 2024
docs/src/content/docs/book/functions.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/book/functions.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/book/functions.mdx Outdated Show resolved Hide resolved
@jeshecdom
Copy link
Contributor

I agree that this is confusing, and I think that the cause is that we are mixing two mental models: a stack (low-level) and tuples (high-level).

We should pick only one and stick with it the entire explanation. It seems that describing everything in terms of tuples is more intuitive, but then we should not mention the stack (or mention how tuples are pushed and popped from a stack in a separate subsection, and only in that section mention the stack).

So, for example, I would start the examples saying something about the TVM instructions, something like this:

"
Even though TVM instructions work with a stack, TVM instructions can be seen, intuitively, as maps from tuples to tuples. To see how TVM instructions map tuples to tuples in the TVM stack, see [link: here]. Thinking in terms of tuples makes the explanation of asm functions much clearer, but for those who want to see an explanation using the stack directly, see [link: here].
"

Then, explaining the meaning of a declaration like:

asm(len self -> 1 0) fun testFun(self: Slice, len: Int): Result { TVM_INSTRUCTION }

struct Result {
   res1: Int;
   res2: Bool;
}

amounts to saying simply:

"
testFun passes the argument tuple (len, self) to instruction TVM_INSTRUCTION. Suppose (r0, r1) is the tuple result of TVM_INSTRUCTION, then testFun reorders the result according to the map -> 1 0, i.e., the 1-th index element (r1) has now index 0, and the 0-th index element (r0) has now index 1, producing the tuple (r1, r0). Finally, testFun assigns the tuple (r1, r0) into the Result struct one field at a time, producing Result {res1: r1, res2: r0}.
"

@novusnota
Copy link
Member Author

@jeshecdom interesting note. The cases with multiple instructions should be covered too. And tuples on TON are denoted with square brackets [], so it's better to use those. Also, it's best for readability to remove parentheses as much as possible, so things like "and the 0-th index element (r0)" will be "and the 0-th index element r0" — no need to add indirection and visual pauses with parens :)

@anton-trunov wdyt about #1061 (comment)?

@anton-trunov
Copy link
Member

TVM instructions can be seen, intuitively, as maps from tuples to tuples.

this is incorrect in a very specific technical sense: a tuple is a TVM data structure that occupy precisely one TVM stack position but can contain multiple other TVM primitives, including tuples

the term you probably intended to use is tensor

@anton-trunov
Copy link
Member

testFun passes the argument tuple (len, self)

I find it confusing

@anton-trunov
Copy link
Member

@novusnota just adapt the corresponding calling convention description from tvm.pdf

@anton-trunov
Copy link
Member

@novusnota you also need to check how structures that are returned from a function are actually encoded

@anton-trunov
Copy link
Member

To fully finish this section, #910 needs to be resolved too

@jeshecdom
Copy link
Contributor

TVM instructions can be seen, intuitively, as maps from tuples to tuples.

this is incorrect in a very specific technical sense: a tuple is a TVM data structure that occupy precisely one TVM stack position but can contain multiple other TVM primitives, including tuples

the term you probably intended to use is tensor

I meant mathematical tuple, but now I see that this would introduce much more confusion because of the technical terms in TVM. So, the explanation should stick with the stack and use the technical terms in TVM.

@jeshecdom
Copy link
Contributor

@jeshecdom interesting note. The cases with multiple instructions should be covered too. And tuples on TON are denoted with square brackets [], so it's better to use those. Also, it's best for readability to remove parentheses as much as possible, so things like "and the 0-th index element (r0)" will be "and the 0-th index element r0" — no need to add indirection and visual pauses with parens :)

@anton-trunov wdyt about #1061 (comment)?

Yeah, we should stick with the stack explanation and use the technical terms in TVM, because I see everyone is confused now :). But the way, a question:

In a function like this:

asm fun testFun(a: Int, b: Int): Result { 
 INS_1
 INS_2 
 .....
 INS_n   // Let us suppose that after INS_n finishes, 
         // there are 5 results in the stack
}

Does Tact know that after executing those instructions, there will be exactly 5 results in the stack?
What happens if struct Result has more than 5 fields? Will Tact pop more than 5 elements from the stack until it fills the struct, having as consequence the popping of elements that are not part of the intended result?

@anton-trunov
Copy link
Member

Does Tact know that after executing those instructions, there will be exactly 5 results in the stack?

not in the current implementation

Will Tact pop more than 5 elements from the stack until it fills the struct

nope (the consequence of the previous answer)

This should be documented, of course, but an even more important question is "are returned structs actually represented as tensors (multiple TVM values)?"

@anton-trunov
Copy link
Member

anton-trunov commented Nov 21, 2024

and, of course, the symmetrical question for input function parameters (including passing structs)

@novusnota
Copy link
Member Author

  1. Added description of the current Tact-flavored assembly from WIP feat: new asm parser #1064
  2. Described everything from the stack point of view, including its "registers"
  3. Refined the overall top-to-bottom reading flow

docs/src/content/docs/book/functions.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/book/functions.mdx Outdated Show resolved Hide resolved
@anton-trunov anton-trunov modified the milestones: v1.6.0, Doc: 2024-12 Dec 4, 2024
@novusnota novusnota requested a review from jeshecdom December 18, 2024 09:42
@novusnota
Copy link
Member Author

novusnota commented Dec 18, 2024

image

All done here, @anton-trunov @jeshecdom.

I'll move to finilizing #1064 and then to other things

Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partially reviewed

docs/src/content/docs/book/assembly-functions.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/book/assembly-functions.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/book/assembly-functions.mdx Outdated Show resolved Hide resolved
…light

Once our link checking plugin updates to the Starlight v0.30.0+ and
Astro v5+ we'll work through the breaking changes (the simple
`@astrojs/upgrade` will do)
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's merge this PR and request more edits with separate doc issues. @jeshecdom if you find anything that's worth further clarification please open new issues with docs.tact-lang.org tag

@anton-trunov anton-trunov merged commit 70f5a70 into main Dec 20, 2024
20 checks passed
@anton-trunov anton-trunov deleted the closes-1011-asm-funs branch December 20, 2024 10:22
@novusnota novusnota mentioned this pull request Dec 20, 2024
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants