Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: comptime expressions for message opcodes #1188

Merged
merged 3 commits into from
Dec 16, 2024
Merged

feat: comptime expressions for message opcodes #1188

merged 3 commits into from
Dec 16, 2024

Conversation

anton-trunov
Copy link
Member

@anton-trunov anton-trunov commented Dec 16, 2024 •
edited
Loading

Issue

Closes #878.

Checklist

  • I have updated CHANGELOG.md
  • I have documented my contribution in docs/ and made the build locally
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@anton-trunov anton-trunov added this to the v1.6.0 milestone Dec 16, 2024
@anton-trunov anton-trunov requested a review from a team as a code owner December 16, 2024 11:07
verytactical
verytactical approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@verytactical verytactical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No yet unknown problems found: typecheck in ids and hashing consistency are better done in separate PRs.

LGTM

@verytactical verytactical merged commit 5eb0fb8 into main Dec 16, 2024
18 checks passed
@verytactical verytactical deleted the message-opcode-expr branch December 16, 2024 13:52
@novusnota novusnota mentioned this pull request Dec 16, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@verytactical verytactical verytactical approved these changes

Assignees

@verytactical verytactical

Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

Generalize message opcodes to arbitrary comptime integer expressions
2 participants
@anton-trunov @verytactical