Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove __tact_verify_address to save gas #1207

Merged
merged 8 commits into from
Dec 18, 2024
Merged

feat: remove __tact_verify_address to save gas #1207

merged 8 commits into from
Dec 18, 2024

Conversation

anton-trunov
Copy link
Member

@anton-trunov anton-trunov commented Dec 18, 2024 •
edited
Loading

There is no more automatic address validation, so the user is supposed to do it manually if it's needed.

Issue

Closes #838.

Checklist

  • I have updated CHANGELOG.md
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@anton-trunov
feat: remove __tact_verify_address to save gas
ebbaa4a 
There is no more automatic address validation, so the user
is supposed to do it manually if it's needed.
@anton-trunov anton-trunov added this to the v1.6.0 milestone Dec 18, 2024
@anton-trunov anton-trunov requested a review from a team as a code owner December 18, 2024 09:54
@novusnota novusnota self-requested a review December 18, 2024 09:56
novusnota
novusnota requested changes Dec 18, 2024
View reviewed changes
docs/src/content/docs/ref/core-common.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/ref/core-common.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/book/exit-codes.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/book/exit-codes.mdx Outdated Show resolved Hide resolved
anton-trunov and others added 4 commits December 18, 2024 14:04
@anton-trunov @novusnota
Update docs/src/content/docs/ref/core-common.mdx
117f0af 
Co-authored-by: Novus Nota <68142933+novusnota@users.noreply.github.com>
@anton-trunov @novusnota
Update docs/src/content/docs/ref/core-common.mdx
c200a1c 
Co-authored-by: Novus Nota <68142933+novusnota@users.noreply.github.com>
@anton-trunov @novusnota
Update docs/src/content/docs/book/exit-codes.mdx
41d3cb9 
Co-authored-by: Novus Nota <68142933+novusnota@users.noreply.github.com>
@anton-trunov @novusnota
Update docs/src/content/docs/book/exit-codes.mdx
a5a7e68 
Co-authored-by: Novus Nota <68142933+novusnota@users.noreply.github.com>
novusnota
novusnota previously approved these changes Dec 18, 2024
View reviewed changes
Shvandre
Shvandre previously approved these changes Dec 18, 2024
View reviewed changes
@anton-trunov anton-trunov self-assigned this Dec 18, 2024
@anton-trunov anton-trunov dismissed stale reviews from novusnota and Shvandre via 9ff9bf4 December 18, 2024 16:22
@anton-trunov anton-trunov mentioned this pull request Dec 18, 2024
Open
@anton-trunov anton-trunov merged commit 9156921 into main Dec 18, 2024
18 checks passed
@anton-trunov anton-trunov deleted the remove-__tact_verify_address branch December 18, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeshecdom jeshecdom jeshecdom left review comments

@Gusarich Gusarich Gusarich approved these changes

@Shvandre Shvandre Shvandre left review comments

@novusnota novusnota novusnota left review comments

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

Remove __tact_verify_address to save gas: address validation can be performed manually
5 participants
@anton-trunov @jeshecdom @Gusarich @novusnota @Shvandre