-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON Schema for Tact configuration #194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff! Please keep it coming 👍
I only have a minor comment below. And perhaps @novusnota as the author of the corresponding issue will add his "2 cents" :)
Swiftly done, nice work @VanishMax! I'm in the process of reviewing and your schema works just great: I see that you took descriptions from the documentation, but could you please clarify, which ones were incorrect? I'd like to re-write that page in the near future, but until then it would be nice to enhance the descriptions in the Schema here — I'll send a couple of suggestions in a moment or two :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @VanishMax! Just a few improvements, which you may commit all at once (from "Files changed" tab):
- Adjusted descriptions
- Added links to docs, where possible or sensible, see:
Note, that such links are clickable in IDEs, modern terminals and editors, such as Neovim or Helix. Therefore, it's nice to add links in such descriptions whenever possible :)
Co-authored-by: Novus Nota <68142933+novusnota@users.noreply.github.com>
Co-authored-by: Novus Nota <68142933+novusnota@users.noreply.github.com>
Co-authored-by: Novus Nota <68142933+novusnota@users.noreply.github.com>
Co-authored-by: Novus Nota <68142933+novusnota@users.noreply.github.com>
Co-authored-by: Novus Nota <68142933+novusnota@users.noreply.github.com>
Co-authored-by: Novus Nota <68142933+novusnota@users.noreply.github.com>
Co-authored-by: Novus Nota <68142933+novusnota@users.noreply.github.com>
Co-authored-by: Novus Nota <68142933+novusnota@users.noreply.github.com>
Co-authored-by: Novus Nota <68142933+novusnota@users.noreply.github.com>
Co-authored-by: Novus Nota <68142933+novusnota@users.noreply.github.com>
Co-authored-by: Novus Nota <68142933+novusnota@users.noreply.github.com>
I think this also deserves an entry in CHANGELOG.md |
…matters" This reverts commit 8da0191.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! Btw, this qualifies for the Tact contributor SBT: https://society.ton.org/contribute-to-tact-compiler. I'll just need your TON wallet address to issue the SBT
Closes #178
Added:
Future work:
tact.config.json
if it exists ton-org/blueprint#94