-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new TVM instructions in stdlib #331
Conversation
fcf640a
to
6a41125
Compare
Seems like https://github.com/tact-lang/tact-emulator doesn't support new opcodes yet: I'm getting |
Looks like you are getting @tact-lang/emulator@4.2.3 instead of 4.3.0 in CI
You might need to update the |
17637a0
to
8676011
Compare
Depends on tact-lang/tact-emulator#13 |
I guess since we won't use tact emulator anymore after the merge of #651, we can ignore that issue and finish this stdlib update. |
That would be awesome! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some old comments of mine + a new one
8676011
to
0013ea0
Compare
40e2b0a
to
b6d80b2
Compare
Looks like you also need to commit the changes to the generated |
@Gusarich Any progress on this? |
d2b71ae
to
656434c
Compare
Let's do a bit of doogfooding here: the more we use our own language features for the stdlib the less bugs those are going to have. And this is important because we are going to do a new release pretty soon |
then what about all other functions from stdlib? Many of them are used in |
It's fine. If it cannot be done easily (at least now), let's not do it. When I ported some stdlib functions to use |
@anton-trunov so should I move the new functions from |
Yes, let's go for it |
Co-authored-by: Anton Trunov <anton.a.trunov@gmail.com>
…d.tact` already && add comments to new functions && remove parameters shuffling
LGTM. Just the specllchecker complaints. Btw, we do have Knip now with |
fixed |
Closes #324