Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load address opt (#370) #373

Merged
merged 7 commits into from
Jun 5, 2024
Merged

Conversation

0kenx
Copy link
Contributor

@0kenx 0kenx commented Jun 3, 2024

Closes #370

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I did not do unrelated and/or undiscussed refactorings

0kenx added 3 commits June 3, 2024 15:42
Signed-off-by: 0kenx <km@nxfi.app>
Signed-off-by: 0kenx <km@nxfi.app>
Signed-off-by: 0kenx <km@nxfi.app>
@anton-trunov
Copy link
Member

Thanks a bunch for helping by contributing a fix! Really appreciate it. Could you please resolve the merge conflicts? Looks like your PR is based on an outdated version of the main branch

0kenx added 2 commits June 3, 2024 18:44
Signed-off-by: 0kenx <km@nxfi.app>
Signed-off-by: 0kenx <km@nxfi.app>
@0kenx
Copy link
Contributor Author

0kenx commented Jun 3, 2024

Merged main

anton-trunov
anton-trunov previously approved these changes Jun 4, 2024
@anton-trunov anton-trunov added this to the v1.3.1 milestone Jun 4, 2024
@anton-trunov anton-trunov self-assigned this Jun 4, 2024
@anton-trunov
Copy link
Member

anton-trunov commented Jun 4, 2024

Hey @0kenx, your contribution qualifies for the Tact contributor SBT, would you mind sharing your TON wallet?

@anton-trunov
Copy link
Member

@0kenx CI is failing. You need to update some of the test snapshots, I tried pushing a fix to your branch but I don't have access. So I pushed it to the Tact repo: ae6f1df.

To do it on your side, you can use the following commands:

yarn gen && yarn build && yarn test -u

@0kenx
Copy link
Contributor Author

0kenx commented Jun 4, 2024

CI fails for some snapshot tests, which I believe are expecting some particular FunC code to be generated, and since my code changed FunC code generation, those tests fail.

Signed-off-by: 0kenx <km@nxfi.app>
@0kenx
Copy link
Contributor Author

0kenx commented Jun 4, 2024

It's now merged and all tests and lints pass on local.

@0kenx
Copy link
Contributor Author

0kenx commented Jun 4, 2024

Hey @0kenx, your contribution qualifies for the Tact contributor SBT, would you mind sharing your TON wallet?

UQCbfeyLatuHjLHkuToQEoF37M9TU-RvQk-XSr9eu75vWteC

@anton-trunov anton-trunov merged commit da6a7f6 into tact-lang:main Jun 5, 2024
3 checks passed
@anton-trunov
Copy link
Member

Thanks a lot! SBT sent

@0kenx 0kenx deleted the fix-address-option branch June 5, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tact generates incorrect __tact_load_address_opt
2 participants