Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chaining for mutable functions #384

Merged
merged 5 commits into from
Jun 8, 2024
Merged

Fix chaining for mutable functions #384

merged 5 commits into from
Jun 8, 2024

Conversation

Gusarich
Copy link
Member

@Gusarich Gusarich commented Jun 7, 2024 •
edited
Loading

Closes #211, Closes #118, Closes #348

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I did not do unrelated and/or undiscussed refactorings

@Gusarich Gusarich added this to the v1.3.1 milestone Jun 7, 2024
anton-trunov
anton-trunov approved these changes Jun 8, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is clever! Wrapping modifying functions to provide a temporary binding for the argument being modified.

@anton-trunov anton-trunov merged commit 19aa043 into tact-lang:main Jun 8, 2024
3 checks passed
@anton-trunov anton-trunov mentioned this pull request Jun 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

@novusnota novusnota Awaiting requested review from novusnota

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3.1
2 participants
@Gusarich @anton-trunov