-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor tests #402
Refactor tests #402
Conversation
remove useless or duplicate tests
remove contracts that do not make much sense, keep very incomplete stdlib tests
delete duplicate tests
it is renamed, implicit-init is moved to types/, reduced testing boilerplate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely massive!
But I wonder if CLI tests are also exported in npm due to package.json#L28. Also, as of now the whole src/
folder is included too. We may want to optimize that, although that's mostly a nitpick.
Description of files
field in package.json
This is an amazing improvement to the codebase! The tests were a big and not very structured mess that was only getting worse. Now it'll be easier to contribute and resolve merge conflicts in PRs! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we also remove the feature-
prefix from .spec.ts
files in e2e tests?
good point! fixed
@novusnota can you please open a new issue about it? we should follow the best practices for npm packaging
@Gusarich good point as well! done |
Closes #346